Skip to content

Properly disable leader election #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Properly disable leader election #2307

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb361a5
Properly disable leader election
sjberman Jul 29, 2024
b691686
Merge branch 'main' into fix/leader-election
sjberman Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/mode/static/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@
// Note: when the leadership is lost, the manager will return an error in the Start() method.
// However, it will not wait for any Runnable it starts to finish, meaning any in-progress operations
// might get terminated half-way.
LeaderElection: true,
LeaderElection: cfg.LeaderElection.Enabled,

Check warning on line 315 in internal/mode/static/manager.go

View check run for this annotation

Codecov / codecov/patch

internal/mode/static/manager.go#L315 

Added line #L315 was not covered by tests
LeaderElectionNamespace: cfg.GatewayPodConfig.Namespace,
LeaderElectionID: cfg.LeaderElection.LockName,
// We're not enabling LeaderElectionReleaseOnCancel because when the Manager stops gracefully, it waits
Expand Down
Loading