Run pre-commit on all files

lucacome · lucacome · commit 84d48e5df5af · 2023-07-17T11:07:30.000-07:00
diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md
@@ -25,7 +25,7 @@ A clear and concise description of what you expected to happen.
 * Kubernetes platform (e.g. Mini-kube or GCP)
 * Details on how you expose the NGINX Gateway Pod (e.g. Service of type LoadBalancer or port-forward)
 * Logs of NGINX container: `kubectl -n nginx-gateway logs -l app=nginx-gateway -c nginx`
-* NGINX Configuration: `kubectl -n nginx-gateway exec <gateway-pod> -c nginx -- nginx -T` 
+* NGINX Configuration: `kubectl -n nginx-gateway exec <gateway-pod> -c nginx -- nginx -T`
 
 **Additional context**
-Add any other context about the problem here. Any log files you want to share.
+Add any other context about the problem here. Any log files you want to share.
diff --git a/.github/ISSUE_TEMPLATE/enhancement.md b/.github/ISSUE_TEMPLATE/enhancement.md
@@ -1,11 +1,11 @@
 ---
-name: Enhancement Request 
-about: Suggest an enhancement for this project 
+name: Enhancement Request
+about: Suggest an enhancement for this project
 labels: 'enhancement'
 ---
 
 <!--
-WARNING: Prior to submitting an enhancement request, we ask that you create a discussion. If you have not yet 
+WARNING: Prior to submitting an enhancement request, we ask that you create a discussion. If you have not yet
 created a discussion related to your request, please do so now: https://github.com/nginxinc/nginx-kubernetes-gateway/discussions/new?category=ideas
 -->
 
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -151,7 +151,7 @@ jobs:
     name: Gateway Conformance Tests
     runs-on: ubuntu-22.04
     needs: vars
-    if: ${{ github.ref_type != 'tag' }}    
+    if: ${{ github.ref_type != 'tag' }}
     steps:
       - name: Checkout Repository
         uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
@@ -163,7 +163,7 @@ jobs:
 
       - name: Docker Buildx
         uses: docker/setup-buildx-action@4c0219f9ac95b02789c1075625400b2acbff50b1 # v2.9.1
-      
+
       - name: Docker meta
         id: meta
         uses: docker/metadata-action@818d4b7b91585d195f67373fd9cb0332e31a7175 # v4.6.0
@@ -182,7 +182,7 @@ jobs:
           nkg_tag=$(echo ${{ steps.meta.outputs.tags }} | cut -d ":" -f 2)
           make update-nkg-manifest NKG_PREFIX=${nkg_prefix} NKG_TAG=${nkg_tag}
         working-directory: ./conformance
-    
+
       - name: Build binary
         uses: goreleaser/goreleaser-action@336e29918d653399e599bfca99fadc1d7ffbc9f7 # v4.3.0
         with:
@@ -202,7 +202,7 @@ jobs:
           cache-from: type=gha
           cache-to: type=gha,mode=max
           pull: true
-      
+
       - name: Build Test Docker Image
         uses: docker/build-push-action@2eb1c1961a95fc15694676618e422e8ba1d63825 # v4.1.1
         with:
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -118,7 +118,7 @@ DEPENDENCIES:
 
 COMPATIBILITY:
 - The Gateway API version: `0.5.1`
-- NGINX version: `1.21.x` * 
+- NGINX version: `1.21.x` *
 - Kubernetes version: `1.21+`
 
 \*the installation manifests use the `nginx:1.21` image, which always points to the latest version of 1.21.x releases.
@@ -146,7 +146,7 @@ If you'd like to give us feedback or get involved, see the [README](https://gith
 
 COMPATIBILITY:
 - The Gateway API version: `0.5.0`
-- NGINX version: `1.21.3` 
+- NGINX version: `1.21.3`
 - Kubernetes version: `1.19+`
 
 CONTAINER IMAGES:
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -90,7 +90,7 @@ Before beginning development, familiarize yourself with the following documents:
 - [Pull Request Guidelines](/docs/developer/pull-request.md): A guide for both pull request submitters and reviewers,
   outlining guidelines and best practices to ensure smooth and efficient pull request processes.
 - [Go Style Guide](/docs/developer/go-style-guide.md): A coding style guide for Go. Contains best practices and
-  conventions to follow when writing Go code for the project. 
+  conventions to follow when writing Go code for the project.
 - [Architecture](/docs/architecture.md): A high-level overview of the project's architecture.
 - [Design Principles](/docs/developer/design-principles.md): An overview of the project's design principles.
 
diff --git a/README.md b/README.md
@@ -9,7 +9,7 @@ For a list of supported Gateway API resources and features, see the [Gateway API
 > Warning: This project is actively in development (beta feature state) and should not be deployed in a production environment.
 > All APIs, SDKs, designs, and packages are subject to change.
 
-Learn about our [design principles](/docs/developer/design-principles.md) and [architecture](/docs/architecture.md). 
+Learn about our [design principles](/docs/developer/design-principles.md) and [architecture](/docs/architecture.md).
 
 ## Getting Started
 
diff --git a/conformance/Makefile b/conformance/Makefile
@@ -43,7 +43,7 @@ load-images: preload-nginx-container ## Load NKG and NGINX containers on configu
 .PHONY: prepare-nkg-dependencies
 prepare-nkg-dependencies: ## Install NKG dependencies on configured kind cluster
 	kubectl apply -f https://github.com/kubernetes-sigs/gateway-api/releases/download/v0.7.1/standard-install.yaml
-	kubectl wait --for=condition=available --timeout=60s deployment gateway-api-admission-server -n gateway-system 
+	kubectl wait --for=condition=available --timeout=60s deployment gateway-api-admission-server -n gateway-system
 	kubectl apply -f ../deploy/manifests/namespace.yaml
 	kubectl create configmap njs-modules --from-file=../internal/mode/static/nginx/modules/src/httpmatches.js -n nginx-gateway
 	kubectl apply -f ../deploy/manifests/nginx-conf.yaml
diff --git a/conformance/README.md b/conformance/README.md
@@ -65,7 +65,7 @@ make install-nkg-local-build
 ```makefile
 make install-nkg-local-no-build
 ```
-**Note:** You can optionally skip the actual *build* step. However, if choosing 
+**Note:** You can optionally skip the actual *build* step. However, if choosing
 this option, the following step *must* be completed manually *before* the build step:
  * Set NKG_PREFIX=<nkg_repo_name> NKG_TAG=<nkg_image_tag> to preferred values.
  * Navigate to `deploy/manifests` and update values in `deployment.yaml` as specified in below code-block.
diff --git a/conformance/provisioner/README.md b/conformance/provisioner/README.md
@@ -20,7 +20,7 @@ https://github.com/nginxinc/nginx-kubernetes-gateway/issues/634). However, it ca
 tests, which expect a Gateway API implementation to provision an independent data plane per Gateway.
 
 > Note: Provisioner uses [this manifest](/deploy/manifests/deployment.yaml) to create an NKG static mode Deployment.
-This manifest gets included into the NKG binary during the NKG build. To customize the Deployment, modify the manifest 
+This manifest gets included into the NKG binary during the NKG build. To customize the Deployment, modify the manifest
 and **re-build** NKG.
 
 How to deploy:
@@ -33,7 +33,7 @@ How to deploy:
    ```
 1. Confirm the provisioner is running in nginx-gateway namespace:
    ```shell
-   kubectl get pods -n nginx-gateway 
+   kubectl get pods -n nginx-gateway
    ```
    ```console
    NAME                                         READY   STATUS    RESTARTS   AGE
diff --git a/deploy/manifests/service/nodeport.yaml b/deploy/manifests/service/nodeport.yaml
@@ -4,7 +4,7 @@ metadata:
   name: nginx-gateway
   namespace: nginx-gateway
 spec:
-  type: NodePort 
+  type: NodePort
   ports: # Update the following ports to match your Gateway Listener ports
   - port: 80
     targetPort: 80
diff --git a/docs/cli-help.md b/docs/cli-help.md
@@ -4,7 +4,7 @@ This document describes the commands available in the `gateway` binary of `nginx
 
 ## Static Mode
 
-This command configures NGINX in the scope of a single Gateway resource. 
+This command configures NGINX in the scope of a single Gateway resource.
 
 Usage:
 
diff --git a/docs/developer/design-principles.md b/docs/developer/design-principles.md
@@ -49,4 +49,4 @@ users monitor the health of NGINX Kubernetes Gateway and to assist in diagnosing
 
 NGINX Kubernetes Gateway must be easy and intuitive to use. This means that it should be easy to install, easy to
 configure, and easy to monitor. Its defaults should be sane and should lead to "out-of-box" success. The documentation
-should be clear and provide meaningful examples that customer's can use to inform their deployments and configurations. 
+should be clear and provide meaningful examples that customer's can use to inform their deployments and configurations.
diff --git a/docs/developer/go-style-guide.md b/docs/developer/go-style-guide.md
@@ -57,7 +57,7 @@ func longFunctionDefinition(
   paramZ bool,
 ) (string, error){}
 
-// and 
+// and
 
 s := myStruct{
   field1: 1,
@@ -73,14 +73,14 @@ func longFunctionDefinition(paramX int, paramY string,
   paramZ bool,
 ) (string, error){}
 
-// or 
+// or
 
 func longFunctionDefinition(
   paramX int, paramY string,
   paramZ bool,
 ) (string, error){}
 
-// or 
+// or
 s := myStruct{field1: 1, field2: 2,
 field3: 3}
 
@@ -174,9 +174,9 @@ dependencies adds side-effects which complicates testing.
 
 DO NOT:
 
-```go 
+```go
 func(int required, int optional) {
-  if optional {...} 
+  if optional {...}
 }
 ```
 
@@ -188,13 +188,13 @@ type Option func (o *Object)
 func Optional(string optional) Option {
   return func (o *Object) {
     o.optional = optional
-  } 
+  }
 }
 
 func (int required, ...Options) {
   for o := range Options {
     o(self)
-  } 
+  }
 }
 ```
 
@@ -270,14 +270,14 @@ Example:
 
 ```go
 func onError(err error) {
-// got an asynchronous error 
+// got an asynchronous error
 }
 
 func ReadAsync(r io.Reader, onError) {
   err := r()
   if err != nil {
     onError(err)
-  } 
+  }
 }
 
 go ReadAsync(reader, onError)
@@ -307,12 +307,12 @@ func readFile(filename string) ([]byte, error) {
     return nil, fmt.Errorf("failed to open file: %w", err)
   }
   defer file.Close()
-  
+
   data, err := ioutil.ReadAll(file)
   if err != nil {
     return nil, fmt.Errorf("failed to read file: %w", err)
   }
-  
+
   return data, nil
 }
 
@@ -454,7 +454,7 @@ type Object struct{
 func New() *Object {
   return &Object{
     subobject: &SubObject{},
-  } 
+  }
 }
 ```
 
@@ -477,7 +477,7 @@ DO NOT:
 ```go
 func(s string) *string {
   s := s + "more strings"
-  return &s // this will move to heap 
+  return &s // this will move to heap
 }
 ```
 
diff --git a/docs/developer/pull-request.md b/docs/developer/pull-request.md
@@ -100,6 +100,6 @@ A FIXME is for things that should be fixed in the future. If FIXMEs cannot be ad
 merged, but they _MUST_ include your username and a link to the issue. For example:
 
 ```go
-// FIXME(username): This is currently a hack to work around known issue X. 
+// FIXME(username): This is currently a hack to work around known issue X.
 // Issue <LINK TO GITHUB ISSUE> will remove need for this work around.
 ```
diff --git a/docs/developer/quickstart.md b/docs/developer/quickstart.md
@@ -87,7 +87,7 @@ This will build the docker image `nginx-kubernetes-gateway:<your-user>`.
    Alternatively, you can update the image name and pull policy by using the following command when applying
    `deployment.yaml`:
 
-   ```shell 
+   ```shell
    cat deploy/manifests/deployment.yaml | sed "s|image: ghcr.io/nginxinc/nginx-kubernetes-gateway.*|image: nginx-kubernetes-gateway:$(whoami)|" | sed "s|imagePullPolicy: Always|imagePullPolicy: IfNotPresent|" | kubectl apply -f -
    ```
 
diff --git a/docs/developer/testing.md b/docs/developer/testing.md
@@ -1,7 +1,7 @@
 # Testing
 
 This document provides guidelines for testing, including instructions on running the unit tests, accessing the code
-coverage report, performing manual testing, and running the conformance tests. By following these guidelines, you will 
+coverage report, performing manual testing, and running the conformance tests. By following these guidelines, you will
 gain a thorough understanding of the project's approach to unit testing, enabling you to ensure code quality, validate
 functionality, and maintain robust test coverage.
 
@@ -78,13 +78,13 @@ Follow the steps below for manual testing:
      ```
    - The statuses of the Gateway API Resources. Make sure they look correct.
      ```shell
-     kubectl describe <resource> <resource name> 
+     kubectl describe <resource> <resource name>
      ```
-   - NGINX proxies traffic successfully (when applicable). 
+   - NGINX proxies traffic successfully (when applicable).
    - [Examples](/examples) work correctly. This will ensure that your changes have not introduced any regressions.
 
 > **Note**
->  
+>
 > Don't limit yourself to happy path testing. Make an effort to cover various scenarios, including edge cases and potential error conditions. By testing a wide range of scenarios, you can uncover hidden issues and ensure the robustness of your changes.
 
 Performing manual testing helps guarantee the stability, reliability, and effectiveness of your changes before
diff --git a/docs/installation.md b/docs/installation.md
@@ -76,9 +76,9 @@ This guide walks you through how to install NGINX Kubernetes Gateway on a generi
 You can gain access to NGINX Kubernetes Gateway by creating a `NodePort` Service or a `LoadBalancer` Service.
 
 > Important
-> 
+>
 > The Service manifests expose NGINX Kubernetes Gateway on ports 80 and 443, which exposes any Gateway [Listener](https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io/v1beta1.Listener) configured for those ports. If you'd like to use different ports in your listeners,
-> update the manifests accordingly. 
+> update the manifests accordingly.
 
 ### Create a NodePort Service
 
diff --git a/docs/release-process.md b/docs/release-process.md
@@ -32,7 +32,7 @@ To create a new release, follow these steps:
 4. If a problem is found, prepare a fix PR, merge it into the main branch and return to the previous step.
 5. Create a release branch with a name that follows the `release-X.Y` format.
 6. Prepare and merge a PR into the release branch to update the repo files for the release:
-    1. Update the tag of NKG container images used in the installation manifests (both the 
+    1. Update the tag of NKG container images used in the installation manifests (both the
     [deployment manifest](../deploy/manifests/deployment.yaml) and the
     [provisioner manifest](../conformance/provisioner/provisioner.yaml)) and docs to `X.Y.Z`.
     2. Ensure that the `imagePullPolicy` is `IfNotPresent` in the installation manifests.
diff --git a/docs/resource-validation.md b/docs/resource-validation.md
@@ -53,7 +53,7 @@ For example, if you create an HTTPRoute with an invalid hostname `cafe.!@#$%exam
 with the following error:
 
 ```shell
-kubectl apply -f coffee-route.yaml 
+kubectl apply -f coffee-route.yaml
 ```
 ```
 The HTTPRoute "coffee" is invalid: spec.hostnames[0]: Invalid value: "cafe.!@#$%example.com": spec.hostnames[0] in body should match '^(\*\.)?[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$'
@@ -70,7 +70,7 @@ you create a Gateway resource with a TCP listener that configures a hostname, th
 following error:
 
 ```shell
-kubectl apply -f prod-gateway.yaml 
+kubectl apply -f prod-gateway.yaml
 ```
 ```
 Error from server: error when creating "prod-gateway.yaml": admission webhook "validate.gateway.networking.k8s.io" denied the request: spec.listeners[1].hostname: Forbidden: should be empty for protocol TCP
diff --git a/docs/running-on-kind.md b/docs/running-on-kind.md
@@ -14,10 +14,10 @@ Create a cluster with `kind`. You can follow their [instructions](https://kind.s
 ```makefile
 make create-kind-cluster
 ```
-    
+
 ## Deploy NGINX Kubernetes Gateway
 
-Follow the [installation](./installation.md) instructions to deploy NGINX Kubernetes Gateway on your Kind cluster. 
+Follow the [installation](./installation.md) instructions to deploy NGINX Kubernetes Gateway on your Kind cluster.
 
 ## Access NGINX Kubernetes Gateway
 
@@ -27,7 +27,7 @@ Forward local ports 8080 and 8443 to ports 80 and 443 of the nginx-gateway Pod:
 kubectl -n nginx-gateway port-forward <pod-name> 8080:80 8443:443
 ```
 
-> Note: NGINX will not listen on any ports until you configure a [Gateway](https://gateway-api.sigs.k8s.io/api-types/gateway/#gateway) resource with a valid listener. 
+> Note: NGINX will not listen on any ports until you configure a [Gateway](https://gateway-api.sigs.k8s.io/api-types/gateway/#gateway) resource with a valid listener.
 
 ## Use NGINX Kubernetes Gateway
 To get started, follow the tutorials in the [examples](../examples) directory.
diff --git a/examples/advanced-routing/README.md b/examples/advanced-routing/README.md
diff --git a/examples/cafe-example/README.md b/examples/cafe-example/README.md
diff --git a/examples/http-header-filter/README.md b/examples/http-header-filter/README.md
diff --git a/examples/traffic-splitting/README.md b/examples/traffic-splitting/README.md
diff --git a/internal/mode/static/nginx/config/maps_template.go b/internal/mode/static/nginx/config/maps_template.go
diff --git a/internal/mode/static/nginx/config/servers_template.go b/internal/mode/static/nginx/config/servers_template.go
diff --git a/internal/mode/static/nginx/config/upstreams_template.go b/internal/mode/static/nginx/config/upstreams_template.go
diff --git a/internal/mode/static/nginx/modules/README.md b/internal/mode/static/nginx/modules/README.md
