Fix gateway manifest

Author: bjee19

internal/controller/state/graph/gateway.go

@@ -179,6 +179,8 @@ func validateGateway(gw *v1.Gateway, gc *GatewayClass, npCfg *NginxProxy) ([]con
 		conds = append(conds, conditions.NewGatewayInvalid("GatewayClass is invalid")...)
 	}
 
+	// Set the unaccepted conditions here, because those make the gateway invalid. We set the unprogrammed conditions
+	// elsewhere, because those do not make the gateway invalid.
 	for _, address := range gw.Spec.Addresses {
 		if address.Type == nil {
 			conds = append(conds, conditions.NewGatewayUnsupportedAddress("AddressType must be specified"))

internal/controller/status/prepare_requests.go

@@ -335,6 +335,8 @@ func prepareGatewayRequest(
 		)
 	}
 
+	// Set the unprogrammed conditions here, because those do not make the gateway invalid.
+	// We set the unaccepted conditions elsewhere, because those do make the gateway invalid.
 	for _, address := range gateway.Source.Spec.Addresses {
 		if address.Value == "" {
 			gwConds = append(gwConds, conditions.NewGatewayAddressNotAssigned("Dynamically assigned addresses for the "+

tests/suite/manifests/upstream-settings-policy/invalid-target-usps.yaml

@@ -5,7 +5,8 @@ metadata:
 spec:
   gatewayClassName: nginx
   addresses:
-    - value: "10.0.0.1"
+    - type: Hostname
+      value: "foo"
   listeners:
     - name: http
       port: 80