Use inline error checking

Kate Osborn · Kate Osborn · commit 62936d31ff19 · 2023-10-10T13:44:18.000-06:00
diff --git a/tests/scale/scale_test.go b/tests/scale/scale_test.go
@@ -118,8 +118,7 @@ func runScaleTest(
 			record = append(record, err.Error())
 		}
 
-		err = writer.Write(record)
-		if err != nil {
+		if err = writer.Write(record); err != nil {
 			t.Fatalf("failed to write time to ready to csv file: %s", err)
 		}
 
@@ -173,8 +172,7 @@ func newResultsWriter(t *testing.T, testName string, resultHeaders ...string) *c
 
 	writer := csv.NewWriter(file)
 
-	err = writer.Write(resultHeaders)
-	if err != nil {
+	if err = writer.Write(resultHeaders); err != nil {
 		t.Fatalf("failed to write headers to csv file: %s", err)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -118,8 +118,7 @@ func runScaleTest(`
`118`	`118`	`record = append(record, err.Error())`
`119`	`119`	`}`
`120`	`120`
`121`		`- err = writer.Write(record)`
`122`		`- if err != nil {`
	`121`	`+ if err = writer.Write(record); err != nil {`
`123`	`122`	`t.Fatalf("failed to write time to ready to csv file: %s", err)`
`124`	`123`	`}`
`125`	`124`
`@@ -173,8 +172,7 @@ func newResultsWriter(t testing.T, testName string, resultHeaders ...string) c`
`173`	`172`
`174`	`173`	`writer := csv.NewWriter(file)`
`175`	`174`
`176`		`- err = writer.Write(resultHeaders)`
`177`		`- if err != nil {`
	`175`	`+ if err = writer.Write(resultHeaders); err != nil {`
`178`	`176`	`t.Fatalf("failed to write headers to csv file: %s", err)`
`179`	`177`	`}`
`180`	`178`