test update for ManagerImpl

Author: miledxz

internal/mode/static/nginx/runtime/manager.go

@@ -29,6 +29,13 @@ type (
 
 var childProcPathFmt = "/proc/%[1]v/task/%[1]v/children"
 
+//go:generate go run github.com/maxbrunsfeld/counterfeiter/v6 . NginxPlusClient
+
+type NginxPlusClient interface {
+	UpdateHTTPServers(upstream string, servers []ngxclient.UpstreamServer) (added []ngxclient.UpstreamServer, deleted []ngxclient.UpstreamServer, updated []ngxclient.UpstreamServer, err error)
+	GetUpstreams() (*ngxclient.Upstreams, error)
+}
+
 //go:generate go run github.com/maxbrunsfeld/counterfeiter/v6 . Manager
 
 // Manager manages the runtime of NGINX.
@@ -56,13 +63,13 @@ type MetricsCollector interface {
 type ManagerImpl struct {
 	verifyClient     *verifyClient
 	metricsCollector MetricsCollector
-	ngxPlusClient    *ngxclient.NginxClient
+	ngxPlusClient    NginxPlusClient
 	logger           logr.Logger
 }
 
 // NewManagerImpl creates a new ManagerImpl.
 func NewManagerImpl(
-	ngxPlusClient *ngxclient.NginxClient,
+	ngxPlusClient NginxPlusClient,
 	collector MetricsCollector,
 	logger logr.Logger,
 ) *ManagerImpl {

internal/mode/static/nginx/runtime/manager_test.go

@@ -4,12 +4,10 @@ import (
 	"context"
 	"errors"
 	"io/fs"
-	"net/http"
 	"testing"
 	"time"
 
 	"github.com/go-logr/logr"
-	"github.com/nginxinc/nginx-plus-go-client/client"
 	ngxclient "github.com/nginxinc/nginx-plus-go-client/client"
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
@@ -23,72 +21,6 @@ var _ = Describe("NGINX Runtime Manager", func() {
 		mgr = NewManagerImpl(&ngxclient.NginxClient{}, nil, logr.New(GinkgoLogr.GetSink()))
 		Expect(mgr.IsPlus()).To(BeTrue())
 	})
-
-	Describe("ManagerImpl", Ordered, func() {
-		var (
-			mockedManager Manager
-			serverMocks   []ngxclient.UpstreamServer
-			serversMock   ngxclient.UpstreamServer
-
-			clientMock *ngxclient.NginxClient
-		)
-
-		var (
-			MaxConnsMock = 150
-			MaxFailsMock = 20
-			WeightMock   = 10
-			BackupMock   = false
-			DownMock     = false
-		)
-
-		BeforeAll(func() {
-
-			serversMock = ngxclient.UpstreamServer{
-				ID:          1,
-				Server:      "unknown",
-				MaxConns:    &MaxConnsMock,
-				MaxFails:    &MaxFailsMock,
-				FailTimeout: "test",
-				SlowStart:   "test",
-				Route:       "test",
-				Backup:      &BackupMock,
-				Down:        &DownMock,
-				Drain:       false,
-				Weight:      &WeightMock,
-				Service:     "",
-			}
-
-			serverMocks = []ngxclient.UpstreamServer{
-				serversMock,
-			}
-
-			httpClient := &http.Client{
-				Transport:     http.DefaultTransport,
-				CheckRedirect: http.DefaultClient.CheckRedirect,
-				Jar:           http.DefaultClient.Jar,
-				Timeout:       time.Second * 4,
-			}
-
-			clientMock, _ = ngxclient.NewNginxClient("test", client.WithHTTPClient(httpClient))
-			logrMock := logr.New(GinkgoLogr.GetSink())
-			mockedManager = NewManagerImpl(clientMock, nil, logrMock)
-
-		})
-
-		It("UpdateHTTPServers fails upon unknown HTTP server upstream", func() {
-			err := mockedManager.UpdateHTTPServers("unknown", serverMocks)
-			Expect(err).ToNot(BeNil())
-		})
-
-		Context("GetUpstreams returns empty map of upstreams", func() {
-			It("returns no upstreams from NGINX Plus API", func() {
-
-				upstreams, err := mockedManager.GetUpstreams()
-				Expect(err).To(HaveOccurred())
-				Expect(upstreams).To(BeEmpty())
-			})
-		})
-	})
 })
 
 func TestEnsureNginxRunning(t *testing.T) {

internal/mode/static/nginx/runtime/runtime_manager_test.go

@@ -0,0 +1,95 @@
+package runtime_test
+
+import (
+	"github.com/go-logr/logr"
+	"github.com/nginxinc/nginx-gateway-fabric/internal/mode/static/nginx/runtime"
+	"github.com/nginxinc/nginx-gateway-fabric/internal/mode/static/nginx/runtime/runtimefakes"
+	ngxclient "github.com/nginxinc/nginx-plus-go-client/client"
+
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+)
+
+var _ = Describe("NGINX Runtime Manager", Ordered, func() {
+	var (
+		manager         runtime.Manager
+		upstreamServers []ngxclient.UpstreamServer
+		upstreamServer  ngxclient.UpstreamServer
+		logger          logr.Logger
+		ngxPlusClient   *runtimefakes.FakeNginxPlusClient
+	)
+
+	var (
+		MaxConnsMock = 150
+		MaxFailsMock = 20
+		WeightMock   = 10
+		BackupMock   = false
+		DownMock     = false
+	)
+
+	BeforeAll(func() {
+		upstreamServer = ngxclient.UpstreamServer{
+			ID:          1,
+			Server:      "10.0.0.1:80",
+			MaxConns:    &MaxConnsMock,
+			MaxFails:    &MaxFailsMock,
+			FailTimeout: "test",
+			SlowStart:   "test",
+			Route:       "test",
+			Backup:      &BackupMock,
+			Down:        &DownMock,
+			Drain:       false,
+			Weight:      &WeightMock,
+			Service:     "test",
+		}
+
+		upstreamServers = []ngxclient.UpstreamServer{
+			upstreamServer,
+		}
+
+		logger = logr.New(GinkgoLogr.GetSink())
+	})
+
+	When("running NGINX plus", func() {
+		BeforeAll(func() {
+			ngxPlusClient = &runtimefakes.FakeNginxPlusClient{}
+			manager = runtime.NewManagerImpl(ngxPlusClient, nil, logger)
+		})
+
+		It("sucessfully updates HTTP server upstream", func() {
+			err := manager.UpdateHTTPServers("test", upstreamServers)
+
+			Expect(err).To(BeNil())
+		})
+
+		It("returns no upstreams from NGINX Plus API", func() {
+			upstreams, err := manager.GetUpstreams()
+
+			Expect(err).To(HaveOccurred())
+			Expect(upstreams).To(BeEmpty())
+		})
+	})
+
+	When("not running NGINX plus", func() {
+		BeforeAll(func() {
+			ngxPlusClient = nil
+			manager = runtime.NewManagerImpl(ngxPlusClient, nil, logger)
+		})
+
+		It("should panic when updating HTTP upstream servers", func() {
+			updateServers := func() {
+				manager.UpdateHTTPServers("test", upstreamServers)
+			}
+
+			Expect(updateServers).To(Panic())
+		})
+
+		It("should panic when fetching HTTP upstream servers", func() {
+			upstreams := func() {
+				manager.GetUpstreams()
+			}
+
+			Expect(upstreams).To(Panic())
+		})
+	})
+})