Skip to content

CentOS 8 is EOL, use CentOS Stream 8 #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2022
Merged

CentOS 8 is EOL, use CentOS Stream 8 #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e649bc9
CentOS 8 is EOL, use CentOS Stream 8
lucacome Feb 16, 2022
0004d48
Merge branch 'master' into deps/centosstream8
lucacome Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:
image: centos7-builder:${{ github.sha }}
run: /build.sh
options: -v ${{ github.workspace }}/build/package/rpm:/rpm -v ${{ github.workspace }}/build_output:/build_output
- name: Build Image Centos 8
- name: Build Image Centos stream 8
uses: docker/build-push-action@v2
with:
file: build/Dockerfile
Expand All @@ -120,14 +120,14 @@ jobs:
load: true
cache-from: type=gha
cache-to: type=gha,mode=max
tags: centos8-builder:${{ github.sha }}
tags: centosstream8-builder:${{ github.sha }}
build-args: |
CONTAINER_VERSION=centos:8
CONTAINER_VERSION=quay.io/centos/centos:stream8
OS_TYPE=rpm_based
- name: Run Centos 8
- name: Run Centos stream 8
uses: addnab/docker-run-action@v3
with:
image: centos8-builder:${{ github.sha }}
image: centosstream8-builder:${{ github.sha }}
run: /build.sh
options: -v ${{ github.workspace }}/build/package/rpm:/rpm -v ${{ github.workspace }}/build_output:/build_output
- name: Build Image Debian
Expand Down
8 changes: 4 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ TARGET ?= local

export DOCKER_BUILDKIT = 1

all: amazon2 centos7 centos8 debian
all: amazon2 centos7 centosstream8 debian

.PHONY: test
test:
Expand All @@ -27,9 +27,9 @@ centos7: build
docker build -t centos7-builder --target ${TARGET} --build-arg CONTAINER_VERSION=centos:7 --build-arg OS_TYPE=rpm_based -f build/Dockerfile .
docker run --rm -v $(shell pwd)/build/package/rpm:/rpm -v $(shell pwd)/build_output:/build_output centos7-builder

centos8: build
docker build -t centos8-builder --target ${TARGET} --build-arg CONTAINER_VERSION=centos:8 --build-arg OS_TYPE=rpm_based -f build/Dockerfile .
docker run --rm -v $(shell pwd)/build/package/rpm:/rpm -v $(shell pwd)/build_output:/build_output centos8-builder
centosstream8: build
docker build -t centosstream8-builder --target ${TARGET} --build-arg CONTAINER_VERSION=quay.io/centos/centos:stream8 --build-arg OS_TYPE=rpm_based -f build/Dockerfile .
docker run --rm -v $(shell pwd)/build/package/rpm:/rpm -v $(shell pwd)/build_output:/build_output centosstream8-builder

debian: build
docker build -t debian-builder --target ${TARGET} --build-arg OS_TYPE=deb_based -f build/Dockerfile .
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ To build a software package, run: `$ make <os>`
where `<os>` is the target OS. The following values are allowed:
* `amazon2` for Amazon Linux 2
* `centos7` for CentOS7/RHEL7
* `centos8` for CentOS8/RHEL8
* `centosstream8` for CentOS Stream 8/RHEL8
* `debian` for Ubuntu >= 16.04 and Debian 9/10

by default the nginx-asg-sync binary will be built locally, to build it inside a Docker container add the `TARGET` parameter to `make`, for example:
Expand Down