Skip to content

Skip GH action *plus* tests only when secrets aren't present #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

alessfg
Copy link
Member

@alessfg alessfg commented Sep 7, 2022

Proposed changes

Update GitHub actions to only skip *plus* scenarios when the NGINX Plus license secrets are not present (it used to only run the NGINX Plus test scenarios during internal PRs).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Sep 7, 2022
@alessfg alessfg added github_actions tests Improvements to tests labels Sep 7, 2022
@alessfg alessfg added this to the 0.23.2 milestone Sep 7, 2022
@alessfg alessfg changed the title Update GitHub actions Skip GH action *plus* tests only when secrets aren't present Sep 7, 2022
@alessfg alessfg merged commit ed72fc7 into main Sep 7, 2022
@alessfg alessfg deleted the update-github-actions branch September 7, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Improvements to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant