feat: disable automatic ACME HTTP challenge location configuration #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nginx-proxy/nginx-proxy#2473 must be merged first, and the last commit removed. |
pini-gh
reviewed
Jun 5, 2024
buchdag
force-pushed
the
disable-location-config-2
branch
from
31bb4dd
to
28bdc6b
Compare
This was referenced Jun 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disable the automatic handling of ACME HTTP challenge location by default, and provides a way to re-enable it with the new
ACME_HTTP_CHALLENGE_LOCATIONenvironment variable.This is done because nginx-proxy will now handle the ACME HTTP challenge location by itself unless told otherwise, which will be less fragile than letting acme-companion fiddle with location files.
Fixes #1091
Ping @pini-gh