Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate scion #69

Closed
augustebaum opened this issue Oct 17, 2023 · 6 comments
Closed

Migrate scion #69

augustebaum opened this issue Oct 17, 2023 · 6 comments
Labels
maintenance Cleanup, refactoring, improving discoverability, tending to continuos integration migration NGI0 Entrust Funded through NGI Zero Entrust

Comments

@augustebaum
Copy link
Contributor

augustebaum commented Oct 17, 2023

https://github.com/ngi-nix/scion

part of #12

Current state:

  • Uses buildGo117Module for most packages, which is not provided by our nixpkgs version.
  • Has some tests, but nix flake check fails:
 '/nix/store/3vc2g0frp09zjkbfdpmj9dlkv25ddp67-source/19-ffaa_1_fe3.tar.gz': No such file or directory

and indeed the file is missing.

  • nix build .#scion works.
  • Provides some modules as well as the packages.

I tried to build it using buildGoModule just to check and got this error:

vendor/github.com/lucas-clemente/quic-go/internal/qtls/go118.go:5:13:
cannot use "quic-go doesn't build on Go 1.18 yet." (untyped string constant) as int value in variable declaration

which seems to suggest there are upstream dependencies that need to be updated before this flake can be ported, as per this recommendation.

@augustebaum augustebaum added the maintenance Cleanup, refactoring, improving discoverability, tending to continuos integration label Oct 17, 2023
@augustebaum
Copy link
Contributor Author

Turns out @sarcasticadmin has been able to bump the Go toolchain version: ngi-nix/scion#7

@mightyiam
Copy link
Member

It seems that nix flake check is failing in master of the ngi-nix/scion repository. And we're not sure it is trivial, so we'll see whether easier tasks are available.

@sarcasticadmin
Copy link
Member

sarcasticadmin commented Oct 21, 2023

Theres some remaining upstream work in scion-apps (netsec-ethz/scion-apps#246) that Im waiting on. But once that lands the drvs in ngi-nix/scion should be much more up-to-date.

@lorenzleutgeb lorenzleutgeb changed the title Move scion to ngipkgs Migrate scion Oct 24, 2023
@sarcasticadmin
Copy link
Member

@mightyiam @augustebaum @lorenzleutgeb All of the upstream work has landed so the PR ngi-nix/scion#7 is ready for review

@mightyiam
Copy link
Member

@fricklerhandwerk what NGI program is this in, please?

@fricklerhandwerk fricklerhandwerk added the NGI0 Entrust Funded through NGI Zero Entrust label Nov 13, 2023
@fricklerhandwerk
Copy link
Collaborator

Closing, as SCION is already being landed in Nixpkgs NixOS/nixpkgs#298737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Cleanup, refactoring, improving discoverability, tending to continuos integration migration NGI0 Entrust Funded through NGI Zero Entrust
Projects
Status: Done
Development

No branches or pull requests

5 participants