added cli option to preserve VPC settings on update; fixes #78 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws_lambda/aws_lambda.py
Outdated
| @@ -111,14 +112,15 @@ def deploy( | |||
|
|
|||
| existing_config = get_function_config(cfg) | |||
| if existing_config: | |||
| update_function(cfg, path_to_zip_file, existing_config) | |||
| update_function(cfg, path_to_zip_file, existing_config, preserve_vpc) | |||
There was a problem hiding this comment.
Needs to pass preserve_vpc value as kwargs.
|
Alright I've made that change to call it using kwargs. Anything else? What is the procedure for getting PRs merged and new releases built? |
|
@nficano is this repo still maintained? Do you have a procedure for merging PRs and getting new releases built? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a command line option called
--preserve-vpcwhich allows you to omit the VPC settings (i.e. subnets and security groups) so that it will preserve whatever settings are already present on updates. This is useful when deploying the same function to multiple accounts where the security groups and subnets will necessarily change.