From 32a7e6b049906ad7cf9366a355672a29d3dcc958 Mon Sep 17 00:00:00 2001 From: Matthias Zepper <6963520+MatthiasZepper@users.noreply.github.com> Date: Fri, 25 Oct 2024 13:26:14 +0200 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Matthias Hörtenhuber --- nf_core/pipelines/download.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/nf_core/pipelines/download.py b/nf_core/pipelines/download.py index 94763b0fc..9a329aeaf 100644 --- a/nf_core/pipelines/download.py +++ b/nf_core/pipelines/download.py @@ -995,15 +995,15 @@ def prioritize_direct_download(self, container_list: List[str]) -> List[str]: A regex that matches http, r"^$|^http" could thus be used to prioritize the Docker URIs over http Downloads We also need to handle a special case: The https:// Singularity downloads from Seqera Containers all end in 'data', although - they are not equivalent: + they are not equivalent, e.g.: 'https://community-cr-prod.seqera.io/docker/registry/v2/blobs/sha256/63/6397750e9730a3fbcc5b4c43f14bd141c64c723fd7dad80e47921a68a7c3cd21/data' 'https://community-cr-prod.seqera.io/docker/registry/v2/blobs/sha256/c2/c262fc09eca59edb5a724080eeceb00fb06396f510aefb229c2d2c6897e63975/data' """ - d: dict[str, str] = {} - seqera_containers: list[str] = [] - all_others: list[str] = [] + d: Dict[str, str] = {} + seqera_containers: List[str] = [] + all_others: List[str] = [] for c in container_list: if bool(re.search(r"/data$", c)):