Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nf-core/atacseq test dataset #13

Merged
merged 3 commits into from
Oct 19, 2018
Merged

Add nf-core/atacseq test dataset #13

merged 3 commits into from
Oct 19, 2018

Conversation

drpatelh
Copy link
Member

This is just the sample design file required for the pipeline. I will be using the reference genome and raw fastq files from the chipseq test-datasets branch.

Please can you check the github links to the fastq files in the design file. I recently asked (on nf-core gitter) how I would get the fastq files into nextflow if they are links. @ewels suggested "If you put in URLs for them (raw.github.com) then nextflow will automatically download them for you". I think I have done what he meant! Couldnt find any documentation anywhere.

Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments / mini changes

Oh: I also changed the branch from master to the right one ;-)

design.csv Show resolved Hide resolved
README.md Show resolved Hide resolved
@apeltzer apeltzer changed the base branch from master to atacseq October 11, 2018 07:17
@drpatelh
Copy link
Member Author

@apeltzer is this ok now? Sorry I don't know if I should do anything else. I think the README should contain all the relevant information. As long as you think I am using the correct GitHub (raw) links to automatically download the fastq files in the design file then I think that should be it. I'll perform some "tests" after the dataset has been approved anyway. Thank you!

@apeltzer apeltzer merged commit 1ccd163 into nf-core:atacseq Oct 19, 2018
@apeltzer
Copy link
Member

Yup all good ! Go ahead :)

apeltzer pushed a commit that referenced this pull request Nov 3, 2020
Getting latest Eager datasets
LouisLeNezet pushed a commit to LouisLeNezet/test-datasets that referenced this pull request Feb 16, 2023
Add nf-core/atacseq test dataset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants