From 5c8cc7a42d1e7a7957c0273ab21555f01d5bac8f Mon Sep 17 00:00:00 2001 From: sohan01fw <121301775+sohan01fw@users.noreply.github.com> Date: Thu, 5 Sep 2024 15:07:05 +0545 Subject: [PATCH] fix(select): prevent select from closing instantly when clicking on label of select (#3568) * fix(select): prevent select from closing instantly when clicking on label * fix(select): flickering on label click * fix(select): flickering while click on label * fix(select): add changeset on fixing the flickering model issue * chore(changeset): revise changeset message and add issue number --------- Co-authored-by: WK Wong --- .changeset/clean-dryers-notice.md | 5 +++++ packages/core/theme/src/components/select.ts | 7 ------- 2 files changed, 5 insertions(+), 7 deletions(-) create mode 100644 .changeset/clean-dryers-notice.md diff --git a/.changeset/clean-dryers-notice.md b/.changeset/clean-dryers-notice.md new file mode 100644 index 0000000000..6c9a8820cb --- /dev/null +++ b/.changeset/clean-dryers-notice.md @@ -0,0 +1,5 @@ +--- +"@nextui-org/select": patch +--- + +Fixed toggle issue while clicking on label of select component unexpectedly open and close the model instantly. The removal of code block containing `group-data-[filled=true]:pointer-events-auto` prevent from any unwanted user interactions and resolve the flickering issue (#3558) diff --git a/packages/core/theme/src/components/select.ts b/packages/core/theme/src/components/select.ts index 24a95b3dc0..4a56725141 100644 --- a/packages/core/theme/src/components/select.ts +++ b/packages/core/theme/src/components/select.ts @@ -535,13 +535,6 @@ const select = tv({ trigger: "h-16 min-h-16 py-2.5 gap-0", }, }, - // labelPlacement=[inside, outside] - { - labelPlacement: ["inside", "outside"], - class: { - label: ["group-data-[filled=true]:pointer-events-auto"], - }, - }, { labelPlacement: "outside", isMultiline: false,