Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum Python version from 3.6 to 3.7 #256

Closed
wants to merge 1 commit into from

Conversation

corneliusroemer
Copy link
Member

@corneliusroemer corneliusroemer commented Feb 24, 2023

Mirrors previous bump commit d7d8196

Motivated by failing CI for 3.6 and by the fact that 3.6's end of life was 23 Dec 2021

A few places in code which handle 3.6 vs. 3.7+ differences still
remain, as they're not enough overhead to rip out (yet).

This change warrants a major version bump for the first release
including it.

Mirrors previous bump commit d7d8196

Motivated by failing CI for a PR with 3.6 and by the fact that 3.6's end of life was 23 Dec 2021

A few places in code which handle 3.6 vs. 3.7+ differences still
remain, as they're not enough overhead to rip out (yet).

This change warrants a major version bump for the first release
including it.
@tsibley
Copy link
Member

tsibley commented Feb 27, 2023

The failing CI is restricted to mypy type checks, nothing functional about Nextstrain CLI on Python 3.6. I think I'd rather fix that small issue rather than drop 3.6 at this time. Dropping 3.6 will likely have a cascade of other consequences (most probably minor) that I'm not keen to deal with at the moment. Agreed though that dropping 3.6 is something we'll do sooner than later.

The following patch fixes mypy on 3.6 for me locally, for example:

diff --git a/setup.py b/setup.py
index b2c1316..041b11c 100644
--- a/setup.py
+++ b/setup.py
@@ -140,7 +140,8 @@ setup(
             "sphinx_rtd_theme",
             "types-docutils",
             "types-setuptools",
-            "types-requests",
+            "types-requests; python_version != '3.6'",
+            "types-requests <=2.28.11.12; python_version == '3.6'",
         ],
     },
 )

The reason why wants a proper write up in the commit message, but two references here are python/typeshed@7180d02 and python/typeshed#9702.

@tsibley
Copy link
Member

tsibley commented Feb 27, 2023

Implemented alternate fix for CI in #257

@tsibley tsibley closed this Feb 27, 2023
@victorlin victorlin deleted the deprecate-py36 branch February 28, 2023 23:12
@victorlin victorlin mentioned this pull request Nov 3, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants