-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncaught error when root not in tree. #1580
Comments
Hi @vanessazubach,
It looks like you have an extra |
Thank you. That did the trick. However the tree it did not work out how I was hoping for it to. Is there a way to define clades as monophyletic or define a common ancestor? I know epidemiologically that sample 353 is the ancestor to 424, 425, 440, 494 and 496, so why are those samples not branching off of that sample? |
Hi @vanessazubach I've also gotten this error before and we should catch it and abort with a clear message to the user about their error. You can pass a constraint tree to iqtree if you want to enforce a certain topology. But this might be overkill. I'd need more context to help with your question. Maybe you can post your general question re tree topology being different than expected ok discussion.nextstrain.org? The forum is better suited for that sort of broad question. |
This should be handled by TreeTime. @corneliusroemer are you able to transfer this issue to neherlab/treetime? |
No, it should be handled by Augur. Treetime can't do anything about a user error. The problem is that augur doesn't catch it. Augur should catch and abort with an appropriate message but not throw an exception. |
Would this not happen for users of TreeTime CLI? This is the error from TreeTime:
|
A better explanation: right now it is throwing raise TreeTimeError(f"Malformed VCF file {vcf_file!r} - all the meta-information (lines starting with ##) must appear at the top of the file.") |
You're right @victorlin! |
Thank you all for your quick attention to this! And thank you @corneliusroemer for your suggestion to provide more information about my scenario and put it in the discussion.nextrain.org, I will do that. |
Current Behavior
Expected behavior
I am trying to run Augur refine. I have added the --root because I know sample 353 was the root to 424, 425,440, 494 and 496, but I am getting these errors saying sequence 424 is not in the tree. When I ran this previously without adding the root argument it was fine, however the cluster with these samples did not start at 353.
The text was updated successfully, but these errors were encountered: