Skip to content

Nmc/1870 Onboarding functionality #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Nmc/1870 Onboarding functionality #59

wants to merge 1 commit into from

Conversation

tobiasKaminsky
Copy link

@tobiasKaminsky tobiasKaminsky commented Apr 3, 2023 •
edited by surinder-tsys
Loading

Onboarding screen customization in NMC.

  • Tests written, or not not needed

@tobiasKaminsky tobiasKaminsky added custom MagentaCLOUD customisation approved labels Apr 3, 2023
@tobiasKaminsky
Copy link
Author

We have FirstRunActivity ith those slides:
https://github.com/nextcloud/android/blob/0946399ba9c2c0ac0dd607dfbb87954de5777a01/app/src/main/java/com/nextcloud/client/onboarding/FirstRunActivity.java#L237

It should be possible to align this.

  • we can configure which buttons should be shown (login, provider, host your own server) via setup.xml
  • extend FeatureItem to show images fullscreen

Can you check if this is possible?

@surinder-tsys surinder-tsys force-pushed the nmc/1870-onboarding branch 2 times, most recently from b6e57e8 to 09fa1e9 Compare April 25, 2023 18:31
@surinder-tsys surinder-tsys force-pushed the nmc/1870-onboarding branch from 80aae38 to a237477 Compare May 15, 2023 15:56
@surinder-tsys surinder-tsys force-pushed the nmc/1870-onboarding branch from 225e050 to 31895aa Compare July 6, 2023 08:35
@surinder-tsys surinder-tsys added the build-ready Customization to include into build label Jul 13, 2023
@surinder-tsys surinder-tsys force-pushed the nmc/1870-onboarding branch 2 times, most recently from d3261a1 to ee3e405 Compare November 2, 2023 07:21
@surinder-tsys surinder-tsys force-pushed the nmc/1870-onboarding branch 2 times, most recently from 2db2a07 to f900764 Compare January 11, 2024 11:18
@surinder-tsys surinder-tsys mentioned this pull request Feb 8, 2024
Closed
@surinder-tsys surinder-tsys changed the title Nmc/1870 onboarding Nmc/1870 Onboarding Functionality Feb 8, 2024
@surinder-tsys surinder-tsys changed the title Nmc/1870 Onboarding Functionality Nmc/1870 Onboarding functionality Feb 8, 2024
@github-actions github-actions bot mentioned this pull request Apr 23, 2024
Closed
@github-actions github-actions bot mentioned this pull request Sep 16, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jan 28, 2025
Open
@github-actions github-actions bot mentioned this pull request Jun 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved build-ready Customization to include into build custom MagentaCLOUD customisation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasKaminsky @surinder-tsys