touching up

Signed-off-by: Alex Knop <knopalex@msu.edu>

Author: alexknop

app/src/main/java/com/owncloud/android/files/services/IndexedForest.java

@@ -215,12 +215,7 @@ public V get(String accountName, String remotePath) {
      * @param accountName
      */
     public void remove(String accountName){
-        for (String key : mMap.keySet()) {
-            Log_OC.d("IndexedForest", "Number of pending downloads= " + mMap.size());
-            if (key.startsWith(accountName)) {
-                mMap.remove(key);
-            }
-        }
+        mMap.keySet().removeIf(key -> key.startsWith(accountName));
     }
 
     /**

app/src/main/java/com/owncloud/android/operations/DownloadFileOperation.java

@@ -196,9 +196,7 @@ protected RemoteOperationResult run(OwnCloudClient client) {
         downloadOperation = new DownloadFileRemoteOperation(file.getRemotePath(), tmpFolder);
 
         if (downloadType == DownloadType.DOWNLOAD) {
-            for (OnDatatransferProgressListener dataTransferListener : dataTransferListeners) {
-                downloadOperation.addDatatransferProgressListener(dataTransferListener);
-            }
+            dataTransferListeners.forEach(downloadOperation::addDatatransferProgressListener);
         }
 
         result = downloadOperation.execute(client);

app/src/main/java/com/owncloud/android/ui/activity/ReceiveExternalFilesActivity.java

@@ -636,13 +636,22 @@ private String internetShortcutDesktopText(String url, String filename) {
 
         @Nullable
         private File createTempFile(String text) {
-            File file = new File(getActivity().getCacheDir(), "tmp.tmp");
+            final var activity = getActivity();
+            if (activity == null) {
+                return null;
+            }
+
+            final var cacheDir = activity.getCacheDir();
+
+            File file = new File(cacheDir, "tmp.tmp");
+
             try (FileWriter fw = new FileWriter(file)) {
                 fw.write(text);
             } catch (IOException e) {
                 Log_OC.d(TAG, "Error ", e);
                 return null;
             }
+
             return file;
         }
     }