-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nf-lang module from language-server #5876
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
I have created the @nextflow-io/compiler team, which consists of just myself. I made this team the code owner of the nf-compiler module so that I can update it without waiting for approval. As long as the tests pass 😄 I would also like to move some classes like ScriptCompiler into this module so that I can consolidate some things, but we can do that in a separate PR if you prefer |
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
ok, i've update the secret |
WaveConfigTest needs to be updated?
|
Oops yes |
@pditommaso tests are passing, ready to merge |
@bentsherman how do you feel calling this module |
It might be appropriate if the module only contained an abstract definition of the language (e.g. the grammar and stdlib interfaces). But because it also contains the concrete implementation of the compiler, |
But I think I'm fine with either name, if you feel strongly about it |
ok, let's go with |
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@pditommaso FYI I am blocked on all other language efforts until this PR is approved |
Let's ship |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Added minor comments
modules/nf-lang/src/main/java/nextflow/config/ast/ConfigApplyBlockNode.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
--------- Signed-off-by: Ben Sherman <bentshermann@gmail.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
--------- Signed-off-by: Ben Sherman <bentshermann@gmail.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
No description provided.