Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nf-lang module from language-server #5876

Merged
merged 18 commits into from
Mar 20, 2025
Merged

Add nf-lang module from language-server #5876

merged 18 commits into from
Mar 20, 2025

Conversation

bentsherman
Copy link
Member

No description provided.

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman bentsherman requested a review from pditommaso March 11, 2025 22:01
Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit e181f37
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/67dc3bfcf093650007cf1cb5
😎 Deploy Preview https://deploy-preview-5876--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman
Copy link
Member Author

I have created the @nextflow-io/compiler team, which consists of just myself. I made this team the code owner of the nf-compiler module so that I can update it without waiting for approval. As long as the tests pass 😄

I would also like to move some classes like ScriptCompiler into this module so that I can consolidate some things, but we can do that in a separate PR if you prefer

@bentsherman

This comment was marked as resolved.

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman

This comment was marked as resolved.

@pditommaso
Copy link
Member

ok, i've update the secret

@bentsherman
Copy link
Member Author

WaveConfigTest needs to be updated?

should dump config

Condition not satisfied:

config.toString() == 'WaveConfig(enabled:true, endpoint:https://wave.seqera.io, containerConfigUrl:[], tokensCacheMaxDuration:30m, condaOpts:CondaOpts(mambaImage=mambaorg/micromamba:1.5.10-noble; basePackages=conda-forge::procps-ng, commands=null), spackOpts:SpackOpts(basePackages=null, commands=null), strategy:[container, dockerfile, conda, spack], bundleProjectResources:null, buildRepository:null, cacheRepository:null, retryOpts:RetryOpts(delay:450ms, maxDelay:1m 30s, maxAttempts:10, jitter:0.25), httpClientOpts:HttpOpts(), freezeMode:null, preserveFileTimestamp:null, buildMaxDuration:40m, mirrorMode:null, scanMode:null, scanAllowedLevels:null)'
|      |          |
|      |          false
|      |          55 differences (3% similarity) (comparing subset start: 217, end1: 219, end2: 274)
|      |          ds(-------------------------------------------------------)
|      |          ds(=null), spackOpts:SpackOpts(basePackages=null, commands)
|      WaveConfig(enabled:true, endpoint:https://wave.seqera.io, containerConfigUrl:[], tokensCacheMaxDuration:30m, condaOpts:CondaOpts(mambaImage=mambaorg/micromamba:1.5.10-noble; basePackages=conda-forge::procps-ng, commands=null), strategy:[container, dockerfile, conda, spack], bundleProjectResources:null, buildRepository:null, cacheRepository:null, retryOpts:RetryOpts(delay:450ms, maxDelay:1m 30s, maxAttempts:10, jitter:0.25), httpClientOpts:HttpOpts(), freezeMode:null, preserveFileTimestamp:null, buildMaxDuration:40m, mirrorMode:null, scanMode:null, scanAllowedLevels:null)
WaveConfig(enabled:true, endpoint:https://wave.seqera.io, containerConfigUrl:[], tokensCacheMaxDuration:30m, condaOpts:CondaOpts(mambaImage=mambaorg/micromamba:1.5.10-noble; basePackages=conda-forge::procps-ng, commands=null), strategy:[container, dockerfile, conda, spack], bundleProjectResources:null, buildRepository:null, cacheRepository:null, retryOpts:RetryOpts(delay:450ms, maxDelay:1m 30s, maxAttempts:10, jitter:0.25), httpClientOpts:HttpOpts(), freezeMode:null, preserveFileTimestamp:null, buildMaxDuration:40m, mirrorMode:null, scanMode:null, scanAllowedLevels:null)

	at io.seqera.wave.plugin.config.WaveConfigTest.should dump config(WaveConfigTest.groovy:189)

@pditommaso
Copy link
Member

Oops yes

@bentsherman
Copy link
Member Author

@pditommaso tests are passing, ready to merge

@pditommaso
Copy link
Member

@bentsherman how do you feel calling this module nf-lang?

@bentsherman
Copy link
Member Author

It might be appropriate if the module only contained an abstract definition of the language (e.g. the grammar and stdlib interfaces). But because it also contains the concrete implementation of the compiler, nf-compiler is more accurate

@bentsherman
Copy link
Member Author

But I think I'm fine with either name, if you feel strongly about it

@pditommaso
Copy link
Member

ok, let's go with nf-lang, we can use to keep all lowe-level lang stuff in the future

@bentsherman bentsherman changed the title Add nf-compiler module from language-server Add nf-lang module from language-server Mar 17, 2025
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman
Copy link
Member Author

@pditommaso FYI I am blocked on all other language efforts until this PR is approved

@pditommaso
Copy link
Member

Let's ship 25.02.1-edge before, then i'll merge this

Copy link
Member

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Added minor comments

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman bentsherman requested a review from pditommaso March 20, 2025 13:57
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@bentsherman bentsherman merged commit 36153c6 into master Mar 20, 2025
22 checks passed
@bentsherman bentsherman deleted the nf-compiler branch March 20, 2025 16:44
adamrtalbot pushed a commit to adamrtalbot/nextflow that referenced this pull request Mar 27, 2025
---------

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
jorgee pushed a commit that referenced this pull request Mar 28, 2025
---------

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants