React to sidebar events from nextcloud-bus#913
Merged
Conversation
d1e526c to
b061a2e
Compare
b061a2e to
225b822
Compare
d602602 to
bf9bdfc
Compare
skjnldsv
reviewed
May 27, 2021
9e1e4ff to
89a18a6
Compare
89a18a6 to
c25d68e
Compare
d7ff8a2 to
74dfc5f
Compare
59 tasks
74dfc5f to
d3a61e1
Compare
cab063f to
2d25756
Compare
skjnldsv
reviewed
Jun 11, 2021
2d25756 to
dff7935
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
dff7935 to
eba1a1b
Compare
Contributor
Author
|
Ok, should be good now @skjnldsv, I am banning |
skjnldsv
approved these changes
Jun 15, 2021
45 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the use of sidebar events dispatched on the
nextcloud-busto open and close the sidebar when the viewer is open.files:sidebar:openedto open the Sidebarfiles:sidebar:closedto close the SidebarNotable changes:
setFullScreenModefunction exposed onOCA.Files.Sidebar. This was necessary because the Sidebar was overriding the programmatically set HTML class..app-sidebar--fullclass toSidebar.vueNeed: