Skip to content

[stable31] fix(viewer): address file path composition for subfolders in public shares #2996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 15, 2025
Merged

[stable31] fix(viewer): address file path composition for subfolders in public shares #2996

merged 4 commits into from
Oct 15, 2025

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Oct 14, 2025 •
edited by skjnldsv
Loading

Backport of #2991

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested a review from skjnldsv October 14, 2025 11:43
@backportbot backportbot bot added the 3. to review Waiting for reviews label Oct 14, 2025
@backportbot backportbot bot added this to the Nextcloud 31.0.10 milestone Oct 14, 2025
@skjnldsv
Copy link
Member

/compile

@skjnldsv skjnldsv marked this pull request as ready for review October 14, 2025 11:44
@tabedzki @backportbot
fix: added the dirPath to the node.path to file comparisons for use i…
75b9136 
…n subfolders in a file share. Previously, node.path for files ina a shaer were `/${file.basename}`

Fixes #2977

Fixes #2976

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

[skip ci]
@backportbot backportbot bot force-pushed the backport/2991/stable31 branch from 6f1731d to 75b9136 Compare October 14, 2025 15:20
@skjnldsv
Copy link
Member

/compile

nextcloud-command and others added 2 commits October 14, 2025 16:21
@nextcloud-command
chore(assets): Recompile assets
dc28448 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv
Merge branch 'stable31' into backport/2991/stable31
55fda05 
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv
Copy link
Member

/compile

@nextcloud-command
chore(assets): Recompile assets
d389133 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv merged commit 9737745 into stable31 Oct 15, 2025
28 of 31 checks passed
@skjnldsv skjnldsv deleted the backport/2991/stable31 branch October 15, 2025 10:22
@blizzz blizzz mentioned this pull request Oct 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 31.0.10

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @tabedzki @nextcloud-command