Merged
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
This comment has been minimized.
This comment has been minimized.
db7bb04 to
d89264f
Compare
This comment has been minimized.
This comment has been minimized.
d89264f to
9086cce
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
9086cce to
af59a47
Compare
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Tests pass locally with nextcloud/server#18251 |
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
Member
|
@skjnldsv Does this land in nextcloud 17 or just 18? |
Member
Author
|
should be both, why? |
Member
|
I am just wondering how quick this will land in a release for end users. |
Member
Author
|
Ah, it should be an easy fix though, it's just a matter of using the proper variables. |
Member
Author
|
@ariselseng ah sorry, actually it's going to be 18 only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes!
The new viewer now provide the full fileinfo access as a vue bind.
Variables names have changed, please update accordingly!
@ariselseng @juliushaertl please be aware of this change!
You can see the default minimal set of props we include in any of the registered views, but you can check by yourself and include your own props so you can use them (example with the Images view that needs the etag, so you just need to addthis as an available prop)
viewer/src/components/Images.vue
Line 59 in af59a47
Any dav property is camelcased and made available