Skip to content

Cleanup and bidn the full fileinfo#299

Merged
skjnldsv merged 3 commits intomasterfrom
fix/fileinfo-standards
Dec 6, 2019
Merged

Cleanup and bidn the full fileinfo#299
skjnldsv merged 3 commits intomasterfrom
fix/fileinfo-standards

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 6, 2019

Breaking changes!
The new viewer now provide the full fileinfo access as a vue bind.
Variables names have changed, please update accordingly!


@ariselseng @juliushaertl please be aware of this change!
You can see the default minimal set of props we include in any of the registered views, but you can check by yourself and include your own props so you can use them (example with the Images view that needs the etag, so you just need to addthis as an available prop)

image

Any dav property is camelcased and made available

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv

This comment has been minimized.

@skjnldsv skjnldsv force-pushed the fix/fileinfo-standards branch from db7bb04 to d89264f Compare December 6, 2019 14:50
@skjnldsv

This comment has been minimized.

@skjnldsv skjnldsv added 3. to review Waiting for reviews enhancement New feature or request labels Dec 6, 2019
@skjnldsv skjnldsv added javascript Javascript related ticket medium Medium priority technical debt Technical issue labels Dec 6, 2019
@cypress

This comment has been minimized.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/fileinfo-standards branch from 9086cce to af59a47 Compare December 6, 2019 15:19
@skjnldsv

This comment has been minimized.

@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 6, 2019

Tests pass locally with nextcloud/server#18251

Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@ariselseng
Copy link
Member

ariselseng commented Dec 9, 2019

@skjnldsv Does this land in nextcloud 17 or just 18?

@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 9, 2019

should be both, why?

@ariselseng
Copy link
Member

I am just wondering how quick this will land in a release for end users.

@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 9, 2019

Ah, it should be an easy fix though, it's just a matter of using the proper variables.
Ping me if you need any help

@skjnldsv
Copy link
Member Author

@ariselseng ah sorry, actually it's going to be 18 only.
There is some very specific stuff for the new sidebar :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request javascript Javascript related ticket medium Medium priority technical debt Technical issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants