Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Jul 29, 2025

Backport of #2894

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from hamza221 and skjnldsv July 29, 2025 10:49
@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews labels Jul 29, 2025
@backportbot backportbot bot added this to the Nextcloud 31.0.8 milestone Jul 29, 2025
@hamza221
Copy link
Contributor

hamza221 commented Jul 29, 2025

While testing this Pr I couldn't open image editor, even on stable31 branch @skjnldsv
image

@hamza221
Copy link
Contributor

/compile

@skjnldsv
Copy link
Member

While testing this Pr I couldn't open image editor, even on stable31 branch @skjnldsv
image

The editor library might have been updated again 🤦‍♂️🤦‍♂️🤦‍♂️
React needs to be pinned and the lib too

@skjnldsv
Copy link
Member

#2911

…itor

Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>

[skip ci]
@hamza221 hamza221 force-pushed the backport/2894/stable31 branch from ce08a2b to cc23a90 Compare July 30, 2025 07:19
@hamza221
Copy link
Contributor

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@hamza221 hamza221 marked this pull request as ready for review July 30, 2025 09:25
@hamza221
Copy link
Contributor

Don't merge just yet, a quick test before

@hamza221
Copy link
Contributor

I rebase but still get the same error ( removed cache even ci & build locally) 🤔
image

@skjnldsv
Copy link
Member

skjnldsv commented Jul 30, 2025

Works for me
image
image

@hamza221 hamza221 merged commit 67c4bd7 into stable31 Jul 30, 2025
34 checks passed
@hamza221 hamza221 deleted the backport/2894/stable31 branch July 30, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants