fix(image-editor): open newly created image when closing the image editor #2894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamza221
force-pushed
the
Fix/save-image-editor
branch
from
216bac4 to
48eb0ae
Compare
|
/compile |
skjnldsv
reviewed
Jun 30, 2025
hamza221
force-pushed
the
Fix/save-image-editor
branch
from
8646b0d to
5073730
Compare
hamza221
force-pushed
the
Fix/save-image-editor
branch
from
5073730 to
72ee207
Compare
skjnldsv
reviewed
Jul 1, 2025
| if (fileId) { | ||
| const newParams = window.OCP.Files.Router.params | ||
| newParams.fileId = fileId | ||
| window.OCP.Files.Router.goToRoute(null, newParams, window.OCP.Files.Router.query) |
There was a problem hiding this comment.
Does this actually works?
Since it's most likely that the file isn't known to the files app yet, specifying an unknown fileid should warn the current user of a file not found toast
There was a problem hiding this comment.
This is added for history/ potential refresh and consistency.
The file is loaded manually in https://github.com/nextcloud/viewer/pull/2894/files#diff-110c577f5691b638686742afb3bc883a4fe999c8ebbfea070ea80c63955c5fc0R665
skjnldsv
approved these changes
Jul 1, 2025
hamza221
force-pushed
the
Fix/save-image-editor
branch
from
7e6a27a to
1a7319b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
hamza221
force-pushed
the
Fix/save-image-editor
branch
from
04d4722 to
69c2a27
Compare
This comment was marked as outdated.
This comment was marked as outdated.
hamza221
force-pushed
the
Fix/save-image-editor
branch
from
b326968 to
1facc5f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
hamza221
force-pushed
the
Fix/save-image-editor
branch
from
0283d07 to
83cac36
Compare
|
/compile |
|
I'm not sure if the cypress failures are related |
No, but something is broken and I cannot find where it's coming from |
…itor Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
hamza221
force-pushed
the
Fix/save-image-editor
branch
from
f23bd81 to
aaed256
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
/backport to stable31 please |
|
/backport to stable30 please |
2 tasks
backportbot
bot
removed
the
backport-request
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduction:
expected behaviour
image2.png is open in viewer