Skip to content

Conversation

@hamza221
Copy link
Contributor

Reproduction:

  1. Make changes
  2. Close editor

Actual behaviour :
Receive 2 consecutive confirmation modal from the editor and then from Nextcloud

Expected behavior:
Confirm once

@hamza221 hamza221 self-assigned this May 12, 2025
@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews labels May 12, 2025
@hamza221 hamza221 requested review from skjnldsv and szaimen May 12, 2025 16:54
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work. However did not review the code

@szaimen szaimen added this to the Nextcloud 32 milestone May 26, 2025
@hamza221
Copy link
Contributor Author

/backport to stable31

@hamza221
Copy link
Contributor Author

/backport to stable30

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label May 26, 2025
@skjnldsv
Copy link
Member

Not too fond of keeping the one from the editor library, as it looks weird.
Is there no way around? Disabling theirs and keeping ours ?

@hamza221
Copy link
Contributor Author

hamza221 commented May 29, 2025

Not too fond of keeping the one from the editor library, as it looks weird. Is there no way around? Disabling theirs and keeping ours ?

There's no config or straight forward way to do it , I can create a PR upstream tho

Edit: scaleflex/filerobot-image-editor#541

@skjnldsv
Copy link
Member

skjnldsv commented May 30, 2025

@hamza221 thanks, but the lib maintainers are not super reactive.
Let's get your PR in 👍

@hamza221 hamza221 force-pushed the Fix/prevent-double-confirmation branch from f0f12dd to 4497eb2 Compare May 30, 2025 10:38
@hamza221 hamza221 enabled auto-merge May 30, 2025 10:38
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 force-pushed the Fix/prevent-double-confirmation branch from 4497eb2 to c1fcd3c Compare May 30, 2025 10:44
@hamza221 hamza221 merged commit 819603b into master May 30, 2025
31 checks passed
@hamza221 hamza221 deleted the Fix/prevent-double-confirmation branch May 30, 2025 10:49
@backportbot
Copy link

backportbot bot commented May 30, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/2814/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c1fcd3cb

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2814/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link

backportbot bot commented May 30, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/2814/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c1fcd3cb

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2814/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants