Skip to content

Conversation

@hamza221
Copy link
Contributor

Looks like the hamburger menu button is not needed, please lmk if I'm missing something.

b a
image image

@hamza221 hamza221 requested a review from skjnldsv May 12, 2025 16:00
@hamza221 hamza221 self-assigned this May 12, 2025
@hamza221 hamza221 added bug Something isn't working design Related to the design 3. to review Waiting for reviews labels May 12, 2025
@hamza221 hamza221 requested a review from szaimen May 20, 2025 15:49
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the screenshots :)

@szaimen szaimen added this to the Nextcloud 32 milestone May 26, 2025
@hamza221
Copy link
Contributor Author

/backport to stable31

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label May 26, 2025
@hamza221
Copy link
Contributor Author

/backport to stable30

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 force-pushed the Fix/image-editor-buttons branch from 8a98171 to 0ca22da Compare May 26, 2025 12:13
@hamza221
Copy link
Contributor Author

rebased to resolve conflicts

@hamza221 hamza221 merged commit bbfe3ce into master May 30, 2025
31 checks passed
@hamza221 hamza221 deleted the Fix/image-editor-buttons branch May 30, 2025 10:40
@backportbot
Copy link

backportbot bot commented May 30, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/2813/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 0ca22da4

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2813/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link

backportbot bot commented May 30, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/2813/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 0ca22da4

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2813/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working design Related to the design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants