-
Notifications
You must be signed in to change notification settings - Fork 58
fix(image-editor): remove hamburger menu button and show close button #2813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the screenshots :)
|
/backport to stable31 |
|
/backport to stable30 |
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
8a98171 to
0ca22da
Compare
|
rebased to resolve conflicts |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/2813/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 0ca22da4
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2813/stable30Error: Failed to check for changes with origin/stable30: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/2813/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 0ca22da4
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2813/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Looks like the hamburger menu button is not needed, please lmk if I'm missing something.