Skip to content

Conversation

@starypatyk
Copy link
Contributor

This PR is related to the nextcloud/photos#1602 in the Photos app, and yet another alternative proposal to #1431.

I agree with @pulsejet comment here: #1431 (comment). Some help from Viewer is needed to support use cases like public albums in Photos.

I am very much open to alternative solutions - e.g. like this: #1431 (comment)

I think it would be really good to pick one - even if not perfect in the long run. The issue with public albums stays open for some time already.

I am missing such function that used to be in the Gallery app (now discontinued) a few years ago. 😞

@szaimen szaimen added the 3. to review Waiting for reviews label Jan 22, 2023
@szaimen szaimen added this to the Nextcloud 26 milestone Jan 22, 2023
@simonspa
Copy link

Seconded, in Photos right now trying to open a photo added by another user in a common album results in:
(Firefox console, local dev setup)

GEThttp://localhost:8210/index.php/core/preview?fileId=10&x=2048&y=1152&a=true
[HTTP/1.1 404 Not Found 121ms]

Loading of file preview 10-photo-1498855592392-af2bf1e0a4c7.jpeg failed, falling back to original file [Images.vue:242](webpack:///viewer/src/components/Images.vue)

Error loading /photos/bob/sharedalbums/shared_with_bob (admin)/10-photo-1498855592392-af2bf1e0a4c7.jpeg 
error { target: img.viewer__file.viewer__file--active, isTrusted: true, srcElement: img.viewer__file.viewer__file--active, currentTarget: img.viewer__file.viewer__file--active, eventPhase: 2, bubbles: false, cancelable: false, returnValue: true, defaultPrevented: false, composed: false, … }

So the core/preview route is attempted.

@simonspa simonspa self-requested a review January 22, 2023 18:13
@skjnldsv
Copy link
Member

Please rebase and compile assets :)

@skjnldsv skjnldsv requested a review from artonge January 31, 2023 09:47
@skjnldsv skjnldsv added the enhancement New feature or request label Jan 31, 2023
@skjnldsv
Copy link
Member

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Jan 31, 2023
@szaimen
Copy link
Contributor

szaimen commented Jan 31, 2023

conflicts...

starypatyk and others added 5 commits January 31, 2023 23:12
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
Co-authored-by: Louis <6653109+artonge@users.noreply.github.com>
Signed-off-by: Dariusz Olszewski <8277636+starypatyk@users.noreply.github.com>
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
@starypatyk starypatyk force-pushed the enh/app-specific-preview-url branch from 4a080e4 to 4b6a2c2 Compare January 31, 2023 22:24
@starypatyk
Copy link
Contributor Author

Please rebase and compile assets :)

Rebased and compiled assets 😉

@skjnldsv skjnldsv merged commit 8aa4b64 into master Feb 1, 2023
@skjnldsv skjnldsv deleted the enh/app-specific-preview-url branch February 1, 2023 06:45
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 1, 2023
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@skjnldsv
Copy link
Member

skjnldsv commented Feb 1, 2023

@starypatyk care to backport this to the stable25 branch? :)

@szaimen szaimen restored the enh/app-specific-preview-url branch February 1, 2023 16:07
@szaimen szaimen deleted the enh/app-specific-preview-url branch February 1, 2023 16:09
@szaimen
Copy link
Contributor

szaimen commented Feb 1, 2023

backport to stable25 here: #1536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish backport-request Pending backport by the backport-bot enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants