Fix onDelete order of operations #1365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pulsejet
commented
Sep 7, 2022
pulsejet
commented
- Always splice the deleted object from the fileList for consistency
- Don't splice the wrong object -- calling previous() first changes currentFile
* Always splice the deleted object from the fileList for consistency * Don't splice the wrong object -- calling previous() first changes currentFile Signed-off-by: Varun Patil <radialapps@gmail.com>
szaimen
requested review from
skjnldsv,
a team,
artonge and
szaimen
and removed request for
a team
This was referenced Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.