Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and simplify plyr theme #1342

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Update and simplify plyr theme #1342

merged 2 commits into from
Aug 23, 2022

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 21, 2022 •
edited
Loading

Simplify our usage and overrides of the plyr theme to be closer to the lib

Video (default primary, light theme) Audio (default primary, light theme)
Peek 21-08-2022 19-33 Capture d’écran_2022-08-21_19-28-10
Dark primary Bright primary
Peek 21-08-2022 19-35 Peek 21-08-2022 19-34

@skjnldsv skjnldsv self-assigned this Aug 21, 2022
@skjnldsv skjnldsv requested review from a team, PVince81, Pytal and szaimen and removed request for a team August 21, 2022 17:28
@skjnldsv skjnldsv added design Related to the design 3. to review Waiting for reviews technical debt Technical issue labels Aug 21, 2022
@skjnldsv skjnldsv added this to the Nextcloud 25 milestone Aug 21, 2022
@skjnldsv skjnldsv requested a review from szaimen August 23, 2022 06:45
@skjnldsv
Copy link
Member Author

/rebase

@skjnldsv
Copy link
Member Author

/compile amend /

@skjnldsv skjnldsv requested a review from artonge August 23, 2022 08:22
szaimen
szaimen approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me then

@skjnldsv
Update and simplify plyr theme
b6f548e 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 23, 2022
@skjnldsv
Properly generate testing builds
0a91024 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit da6d20e into master Aug 23, 2022
@skjnldsv skjnldsv deleted the feat/plyr-design-update branch August 23, 2022 10:55
@blizzz blizzz mentioned this pull request Aug 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@szaimen szaimen szaimen approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish design Related to the design technical debt Technical issue
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @artonge @szaimen