-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setFullScreenMode on talk viewer opening #1331
Conversation
/backport to stable24 |
/rebase |
cffe295
to
88814c7
Compare
/compile amend / |
88814c7
to
37baf15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have reproduction steps? I have never seen that error (and I also tried to reproduce it without success), and it should not happen, as the fake sidebar has a setFullScreenMode
function.
If the issue is caused by Talk I think it would be better to fix it in Talk instead (if it is possible, which I do not know :-) ).
Maybe I was too much behind lol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I was too much behind lol
More than a year, it is surprising that Talk even loaded :-O
In any case, this is good sanity check ;)
Then typeof OCA?.Files?.Sidebar?.setFullScreenMode === 'function'
? Or that is too much? :-P
Anyway, fine by me to keep the old code, to check if setFullScreenMode
exists or to check if setFullScreenMode
is a function 👍
37baf15
to
60c475e
Compare
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
60c475e
to
2732f1b
Compare
The backport to stable24 failed. Please do this backport manually. |
Because Talk is doing some shenanigans to fake the Files Sidebar