Skip to content

Commit abe8d31

Browse files
committed
Fix wait on base url
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
1 parent 8467372 commit abe8d31

File tree

6 files changed

+27
-45
lines changed

6 files changed

+27
-45
lines changed

.drone.yml

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ name: cypress-e2e-testing master
2525
services:
2626
# nextcloud server
2727
- name: server
28-
image: nextcloudci/server:server-15
28+
image: nextcloudci/server:server-16
2929
commands:
3030
# Add app sources to the app directory
3131
- export BRANCH=$DRONE_TARGET_BRANCH
@@ -37,7 +37,7 @@ services:
3737
- chown -R www-data:www-data /var/www/html/data
3838

3939
# Install nextcloud, watch logs and run apache
40-
- bash /usr/local/bin/initnc.sh
40+
- bash /usr/local/bin/initAndRun.sh
4141

4242
steps:
4343
# clone and build the app
@@ -57,14 +57,13 @@ steps:
5757
- name: wait-on-server
5858
image: nextcloudci/node:node-5
5959
environment:
60-
CYPRESS_baseUrl: http://server/index.php/
61-
LOGIN: login
60+
CYPRESS_baseUrl: http://server/index.php
6261
commands:
63-
- WAIT_ON=$CYPRESS_baseUrl$LOGIN
62+
- WAIT_ON=$CYPRESS_baseUrl
6463
# Add app sources to the app directory
6564
- echo "Waiting for $WAIT_ON"
6665
- npm install -g wait-on
67-
- wait-on -i 500 -t 300000 $WAIT_ON
66+
- wait-on -i 500 -t 120000 $WAIT_ON
6867

6968
- name: testing 1
7069
image: cypress/browsers:chrome69
@@ -91,7 +90,6 @@ steps:
9190
CYPRESS_baseUrl: http://server/index.php/
9291
LOGIN: login
9392
commands:
94-
- export DEBUG=cypress:*
9593
- cd /drone/src
9694
- $(npm bin)/cypress run --record --key $CYPRESS_RECORD_TOKEN --parallel --ci-build-id ci-$DRONE_BUILD_NUMBER-master
9795

@@ -120,7 +118,6 @@ steps:
120118
CYPRESS_baseUrl: http://server/index.php/
121119
LOGIN: login
122120
commands:
123-
- export DEBUG=cypress:*
124121
- cd /drone/src
125122
- $(npm bin)/cypress run --record --key $CYPRESS_RECORD_TOKEN --parallel --ci-build-id ci-$DRONE_BUILD_NUMBER-master
126123

@@ -149,7 +146,6 @@ steps:
149146
CYPRESS_baseUrl: http://server/index.php/
150147
LOGIN: login
151148
commands:
152-
- export DEBUG=cypress:*
153149
- cd /drone/src
154150
- $(npm bin)/cypress run --record --key $CYPRESS_RECORD_TOKEN --parallel --ci-build-id ci-$DRONE_BUILD_NUMBER-master
155151

@@ -178,7 +174,6 @@ steps:
178174
CYPRESS_baseUrl: http://server/index.php/
179175
LOGIN: login
180176
commands:
181-
- export DEBUG=cypress:*
182177
- cd /drone/src
183178
- $(npm bin)/cypress run --record --key $CYPRESS_RECORD_TOKEN --parallel --ci-build-id ci-$DRONE_BUILD_NUMBER-master
184179

cypress/start.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ else
99
echo "Launching docker server for the $appname app"
1010
dockername="cypress_testing_$appname"
1111

12-
docker run -p 8000:80 --rm --name $dockername --volume $(pwd):/var/www/html/apps/$appname --env BRANCH=master --detach nextcloudci/server:server-15
12+
docker run -p 8000:80 --rm --name $dockername --volume $(pwd):/var/www/html/apps/$appname --env BRANCH=master --detach nextcloudci/server:server-16
1313
npm i --no-save wait-on
1414
npm run wait-on -- http://localhost:8000
1515
docker exec --user www-data $dockername php occ app:enable $appname

js/viewer.js

Lines changed: 13 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/viewer.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock.json

Lines changed: 3 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webpack.common.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@ const path = require('path')
22
const webpack = require('webpack')
33
const { VueLoaderPlugin } = require('vue-loader')
44
const StyleLintPlugin = require('stylelint-webpack-plugin')
5-
const packageJson = require('./package.json')
6-
const appName = packageJson.name
7-
const appVersion = JSON.stringify(packageJson.version)
5+
6+
// always use the require(package.json) directly to not create compile issues
7+
const appName = require('./package.json').name
8+
const appVersion = JSON.stringify(require('./package.json').version)
89

910
module.exports = {
1011
entry: path.join(__dirname, 'src', 'main.js'),

0 commit comments

Comments
 (0)