[stable31] fix(sync): lastSavedVersion is version send with the request #7698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client sends a serialized version of the document plus the document state according to the steps it received until that point (maybe plus local edits that were not synced yet). lastSavedVersion should be the version the client had seen at the time it initiated the save request not the last version of any step the server saw when receiving the request. Otherwise when loading the document or attempting to recover from missing steps the steps in between will be left out. Signed-off-by: Max <max@nextcloud.com>
backportbot
bot
requested review from
max-nextcloud and
mejo-
as code owners
mejo-
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #7694