[stable32] fix(createEditor): always provide editor. #7646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=80&v=4){kind=small}
Set content after providing the editor. If the content contains links the editor renders `PreviewOptions`. Rendering another component breaks the context of the setup function. Namely `setCurrentInstance` gets called in the vue runtime overwriting the current instance. This leads to `provide` not working anymore as it has no current instance to work with. Signed-off-by: Max <max@nextcloud.com>
Make use of the `useEditorMethods` `setContent` in BaseReader which already handles markdown and plaintext well. Remove the now suprefluous `renderHtml` provide & inject. Signed-off-by: Max <max@nextcloud.com>
backportbot
bot
requested review from
max-nextcloud and
mejo-
as code owners
JuliaKirschenheuter
approved these changes
Sep 16, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable32 #7646 +/- ##
============================================
+ Coverage 52.92% 59.69% +6.77%
============================================
Files 503 502 -1
Lines 43807 38847 -4960
Branches 1129 1128 -1
============================================
+ Hits 23184 23191 +7
+ Misses 20514 15548 -4966
+ Partials 109 108 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #7643