-
Couldn't load subscription status.
- Fork 107
Fixes for TextDirection extension #7509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jonas <jonas@freesources.org>
|
/backport to stable31 |
|
/backport to stable30 |
479e32c to
16c1c7a
Compare
Signed-off-by: Jonas <jonas@freesources.org>
Amongh other things, fixes the `undoInputRule()` command. Signed-off-by: Jonas <jonas@freesources.org>
Also fix some CSS rules to work with rtl script. Signed-off-by: Jonas <jonas@freesources.org>
16c1c7a to
30aa6ad
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7509 +/- ##
==========================================
+ Coverage 52.81% 59.74% +6.93%
==========================================
Files 496 496
Lines 42772 37990 -4782
Branches 1091 1120 +29
==========================================
+ Hits 22589 22698 +109
+ Misses 20075 15185 -4890
+ Partials 108 107 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for tackling this!
|
amirhhashemi/tiptap-text-direction#22 is the upstream PR for the first fix. |
📝 Summary
Use a local copy of TextDirection for now until the issues got fixed upstream.
Adding
calloutandtableCelldidn't work out of the box and need further investigation. I would consider this as a follow-up.🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)