Skip to content

Conversation

@mejo-
Copy link
Member

@mejo- mejo- commented Jul 28, 2025

📝 Summary

Use a local copy of TextDirection for now until the issues got fixed upstream.

Adding callout and tableCell didn't work out of the box and need further investigation. I would consider this as a follow-up.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- self-assigned this Jul 28, 2025
@mejo- mejo- requested a review from max-nextcloud as a code owner July 28, 2025 17:47
@mejo- mejo- added bug Something isn't working 3. to review labels Jul 28, 2025
@mejo-
Copy link
Member Author

mejo- commented Jul 28, 2025

/backport to stable31

@mejo-
Copy link
Member Author

mejo- commented Jul 28, 2025

/backport to stable30

@mejo- mejo- force-pushed the fix/text_direction branch 2 times, most recently from 479e32c to 16c1c7a Compare July 28, 2025 17:52
mejo- added 3 commits July 28, 2025 19:55
Signed-off-by: Jonas <jonas@freesources.org>
Amongh other things, fixes the `undoInputRule()` command.

Signed-off-by: Jonas <jonas@freesources.org>
Also fix some CSS rules to work with rtl script.

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/text_direction branch from 16c1c7a to 30aa6ad Compare July 28, 2025 17:55
@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 88.09524% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.74%. Comparing base (83dfe0c) to head (30aa6ad).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/extensions/TextDirection.ts 87.28% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7509      +/-   ##
==========================================
+ Coverage   52.81%   59.74%   +6.93%     
==========================================
  Files         496      496              
  Lines       42772    37990    -4782     
  Branches     1091     1120      +29     
==========================================
+ Hits        22589    22698     +109     
+ Misses      20075    15185    -4890     
+ Partials      108      107       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for tackling this!

@max-nextcloud
Copy link
Collaborator

amirhhashemi/tiptap-text-direction#22 is the upstream PR for the first fix.

@mejo- mejo- merged commit 35a9c53 into main Jul 29, 2025
66 checks passed
@mejo- mejo- deleted the fix/text_direction branch July 29, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants