[stable31] fix(share): use relative path in share as davPath for attachments #7508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide relative path to attachments in public shares. The path needs to be relative to the shared folder. Open attachments in public collective shares as well as in folder descriptions of public shares. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Only in folder description though as we do not allow it from the viewer. Signed-off-by: Max <max@nextcloud.com>
mejo-
force-pushed
the
backport/7477/stable31
branch
from
a3c99cc to
b9b9650
Compare
mejo-
approved these changes
Jul 30, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable31 #7508 +/- ##
=========================================
Coverage 51.54% 51.54%
=========================================
Files 292 292
Lines 41472 41472
Branches 875 875
=========================================
Hits 21377 21377
Misses 19974 19974
Partials 121 121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Jonas <jonas@freesources.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7477
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.