fix(workspace): toggle right away and only render if needed #7501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7501 +/- ##
=======================================
Coverage 59.64% 59.65%
=======================================
Files 495 495
Lines 37869 37866 -3
Branches 1090 1090
=======================================
+ Hits 22588 22589 +1
+ Misses 15174 15170 -4
Partials 107 107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
max-nextcloud
force-pushed
the
chore/fix-cypress-tests
branch
12 times, most recently
from
196db02 to
188f706
Compare
Awaiting the request for the file lead to race conditions: * Enter directory with rich workspace, loading is triggered. * Navigate to directory without rich workspace. * Loading finishes - rich workspace was shown. Also clean up some minor things: * `this.creating` was not used at all. * The Editor does not emit `error`. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
chore/fix-cypress-tests
branch
from
9a98dd1 to
ce387af
Compare
The header is just hidden if enabled is false. But for the workspace this leads to continuous requests updating the content. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
chore/fix-cypress-tests
branch
from
ce387af to
1a8f287
Compare
max-nextcloud
changed the title
mejo-
approved these changes
Jul 27, 2025
|
Probably also a fix worth backporting, no? |
|
/backport to stable31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7505