[stable31] Several link bubble/preview fixes #7476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
force-pushed
the
backport/7474/stable31
branch
from
0379583 to
0d2d3e6
Compare
mejo-
approved these changes
Jul 26, 2025
mejo-
force-pushed
the
backport/7474/stable31
branch
2 times, most recently
from
31fe112 to
059ca56
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## stable31 #7476 +/- ##
=========================================
Coverage 58.34% 58.34%
=========================================
Files 290 290
Lines 36341 36391 +50
Branches 840 840
=========================================
+ Hits 21204 21234 +30
- Misses 15017 15037 +20
Partials 120 120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Jonas <jonas@freesources.org>
We have a custom node for displaying images anyway. This fixes the cursor being a pointer in the preview images of preview links. Signed-off-by: Jonas <jonas@freesources.org>
Fixes: #1226 Signed-off-by: Jonas <jonas@freesources.org>
When initiating the editor extensions (i.e. in `addProseMirrorPlugins()`), `editor.contentComponent` is not yet available. So let's read it when we actually use it, when creating the tooltip in `LinkBubblePluginView`. Before, a new Vue instance was initiated for each `LinkBubbleView.vue` as the `parent` given to `VueRenderer()` was `undefined`. With this fix, `LinkBubbleView.vue` becomes a child component of the root editor Vue instance. Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
backport/7474/stable31
branch
from
059ca56 to
254a5a2
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7474
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.