fix: catch all errors when getting rich workspace content #6243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable29 |
|
/backport to stable28 |
juliushaertl
approved these changes
Aug 21, 2024
ChristophWurst
approved these changes
Aug 21, 2024
lib/DAV/WorkspacePlugin.php
Outdated
| @@ -96,7 +96,7 @@ public function propFind(PropFind $propFind, INode $node) { | |||
| try { | |||
| $cachedContent = $file->getContent(); | |||
| $cache->set($cacheKey, $cachedContent, 3600); | |||
| } catch (GenericFileException|NotPermittedException|LockedException $e) { | |||
| } catch (\Exception $e) { | |||
There was a problem hiding this comment.
nit: shall we log this, at least with debug level?
There was a problem hiding this comment.
Changed to still ignore file, permission and locking exception but log anything else as error
Signed-off-by: Robin Appelman <robin@icewind.nl> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
dav-workspace-catch-more
branch
from
d3210f8
to
aadec5e
Compare
This was referenced Aug 22, 2024
|
/backport to stable30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't let errors to load a single file become errors for loading the entire directory.