Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cy): adjust share test to api change #6060

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix(cy): adjust share test to api change #6060

merged 1 commit into from
Jul 19, 2024

Conversation

max-nextcloud
Copy link
Collaborator

@max-nextcloud max-nextcloud commented Jul 18, 2024 •
edited
Loading

📝 Summary

enabled is now value.
See nextcloud/server#46007.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests are fixed with this.
  • No docs needed.

@max-nextcloud
fix(cy): adjust share test to api change
768c3a9 
`enabled` is now `value`.
See nextcloud/server#46007.

Signed-off-by: Max <max@nextcloud.com>
juliushaertl
juliushaertl approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@juliushaertl juliushaertl added tests If you write them we ♥ you 4. to release labels Jul 18, 2024
@juliushaertl juliushaertl added this to the Nextcloud 30 milestone Jul 18, 2024
@max-nextcloud
Copy link
Collaborator Author

test in question is passing again now.

@max-nextcloud max-nextcloud merged commit ec8bdd6 into main Jul 19, 2024
59 of 61 checks passed
@max-nextcloud max-nextcloud deleted the fix/cypress-share-test branch July 19, 2024 06:23
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

Assignees
No one assigned
Labels
4. to release tests If you write them we ♥ you
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
2 participants
@max-nextcloud @juliushaertl