Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SmartPicker): Insert smart picker links as preview per default #5846
fix(SmartPicker): Insert smart picker links as preview per default #5846
Changes from all commits
bc5f65c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 175 in cypress/e2e/nodes/Preview.spec.js
GitHub Actions / NPM lint
Check warning on line 175 in cypress/e2e/nodes/Preview.spec.js
GitHub Actions / NPM lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a bit unexpected that the preview node still has an additional mark, can you tell why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it matches the data structure created otherwise. We basically change the wrapping block node between paragraph and preview when switching between the two:
The
setPreview
function above converts the surrounding paragraph of a link into a preview node:If you look at
unsetPreview
above it also only unwraps the link inside the preview node: