test(cypress): Avoid failure when editor is updated on webdav requests #5772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
max-nextcloud
approved these changes
May 8, 2024
|
/backport to stable29 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
|
/backport to stable28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the propfind tests more stable.
We manually upload different file content through webdav which might cause the current editor to throw an exception when the file is deleted.
In the end we don't really need the page context for the tests, however as we use the Nextcloud dav client, asserting propfind responses is a lot easier. Mid-term we could migrate to just use axios or cy.request for those.
Example failure can be seen in https://github.com/nextcloud/text/actions/runs/8952598767/job/24590191037?pr=5762.