Skip to content

Conversation

@mejo-
Copy link
Member

@mejo- mejo- commented Mar 20, 2024

This is only a partial fix so far. We'll have to wait for the icon renames in server and the introduction of icon-add-folder-description in nextcloud/server#44340.

Fixes: #5535

@mejo- mejo- added this to the Nextcloud 29 milestone Mar 20, 2024
@mejo- mejo- self-assigned this Mar 20, 2024
@Pytal Pytal force-pushed the fix/files_menu_icons branch from b922b4b to 348d4e1 Compare March 20, 2024 20:15
@Pytal
Copy link
Member

Pytal commented Mar 20, 2024

Pushed a few updates!

Note

#969696 is used for the article svg instead of --color-text-maxcontrast to be consistent with the mimetype icons rendered in files which uses a background-image url that does not support CSS variables

@Pytal Pytal force-pushed the fix/files_menu_icons branch 2 times, most recently from 3c28895 to 2db29d2 Compare March 21, 2024 19:21
@Pytal Pytal marked this pull request as ready for review March 21, 2024 19:21
@Pytal Pytal requested a review from juliusknorr March 21, 2024 19:21
mejo- and others added 4 commits March 21, 2024 20:23
…iption

Fixes: #5535

Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@juliusknorr juliusknorr force-pushed the fix/files_menu_icons branch from 2db29d2 to 3c61575 Compare March 21, 2024 19:23
@juliusknorr
Copy link
Member

Rebased again to take the nextcloud/ocp update into account

@Pytal Pytal enabled auto-merge March 21, 2024 19:34
@Pytal Pytal merged commit 3143128 into main Mar 21, 2024
@Pytal Pytal deleted the fix/files_menu_icons branch March 21, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Update icons in "New" menu

3 participants