Use the color-primary-element* variables #4178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
added
bug
1 failed and 2 flaky tests on run #9824 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Test the rich text editor menu bar > word count > empty file |
Output
Screenshots
|
|
sync.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Sync > recovers from a lost connection |
Output
Screenshots
|
|
SessionApi.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| The session Api > open the session > returns connection |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
mejo-
approved these changes
May 15, 2023
|
Thanks @szaimen! Shall we backport this to stable26 and stable25? |
Signed-off-by: Simon L <szaimen@e.mail.de>
mejo-
force-pushed
the
enh/noid/use-primary-element
branch
from
4e785ba to
815372a
Compare
|
/compile |
Feel free to but not doing so would be fine as well imo |
|
Let's keep this for 27 for now as I'm not fully sure we backported all recent adaptions of the css variables to those branches. |
juliusknorr
approved these changes
May 15, 2023
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: the color-primary variables are not to be used in components because the introduce problems with high-contrast primary colors. Fix this by using the primary-element variables instead.