Skip to content

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Oct 3, 2022

  • ⚠️ This backport had conflicts and is incomplete

backport of #3074

@backportbot-nextcloud backportbot-nextcloud bot added bug Something isn't working design Experience, interaction, interface, … labels Oct 3, 2022
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 25 milestone Oct 3, 2022
@vinicius73
Copy link
Member

/compile

@blizzz blizzz mentioned this pull request Oct 3, 2022
3 tasks
@blizzz
Copy link
Member

blizzz commented Oct 3, 2022

some CI is failing. Is this even ready for review?

@vinicius73
Copy link
Member

vinicius73 commented Oct 3, 2022

some CI is failing. Is this even ready for review?

One of CI error is related to recent changes on server nextcloud/server#34331

The other is "flaky", we should turn it more efficient.

@blizzz
Copy link
Member

blizzz commented Oct 3, 2022

Ok, thanks for the clarification. Could you update the description and label?

@vinicius73
Copy link
Member

Waiting for nextcloud/server#34396 to merge it safely.

@blizzz
Copy link
Member

blizzz commented Oct 3, 2022

is merged

Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
@mejo- mejo- force-pushed the backport/3074/stable25 branch from 78f2aee to 22084b3 Compare October 5, 2022 11:26
@mejo-
Copy link
Member

mejo- commented Oct 5, 2022

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also good to be merged now.

@blizzz blizzz merged commit 3a7c62e into stable25 Oct 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the backport/3074/stable25 branch October 5, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing bug Something isn't working design Experience, interaction, interface, …

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants