-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @nextcloud/vue to 6.0.0-beta.3 #2794
Conversation
db0042d
to
672e2e7
Compare
2fede0f
to
1104374
Compare
viewer has been updated to vue 2.7 There no more errors like vuejs/vue#12627 |
I just found a style error, it seems to work correctly. The main problem is the new popover component (floating-vue). I will send a PR to nextcloud-vue to address some of that behaviors. |
a253e31
to
c32eae4
Compare
@vinicius73 I pushed an adjustment to the cypress selectors and it seems to be happy about that. Also ran another smoke test an couldn't find any obvious issues. Maybe you can later list your findings, so we have that tracked. Voting for getting this in fast, we can still follow up on smaller issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested against server master branch, working well! :)
|
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Bumps [@nextcloud/eslint-config](https://github.com/nextcloud/eslint-config) from 8.0.0 to 8.1.2. - [Release notes](https://github.com/nextcloud/eslint-config/releases) - [Changelog](https://github.com/nextcloud/eslint-config/blob/master/CHANGELOG.md) - [Commits](nextcloud-libraries/eslint-config@v8.0.0...v8.1.2) --- updated-dependencies: - dependency-name: "@nextcloud/eslint-config" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2a7654d
to
ff3f55e
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
ff3f55e
to
158a611
Compare
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Still throwing some errors in the viewer as nextcloud/viewer#1319 / nextcloud/viewer#1300 are missing and the Vue instance has a different version there.
Ref vuejs/vue#12627
At some point we should probably rethink our way of embedding text in viewer to avoid version dependencies like that.