Block file access for secure view #2776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable24 |
juliusknorr
force-pushed
the
enh/secure-view
branch
2 times, most recently
from
b1bf008 to
7872390
Compare
max-nextcloud
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
Code looks good.
I think it would be good to have this covered with a test:
- It's hard to test by hand as it seems to involve issueing a curl request to remove the download permission as outlined in the linked server PR.
- It has security relevance
- We might break it accidentally at some point because it's a corner case we don't remember.
juliusknorr
force-pushed
the
enh/secure-view
branch
from
7872390 to
e4dd6aa
Compare
|
Rebased and pushed a small cypress test. |
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
max-nextcloud
approved these changes
Dec 20, 2022
|
/compile |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
max-nextcloud
force-pushed
the
enh/secure-view
branch
from
4d8c618 to
1edacdf
Compare
|
/backport to stable25 |
|
The backport to stable24 failed. Please do this backport manually. |
|
The backport to stable25 failed. Please do this backport manually. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
/backport af55553 to stable24 |
|
/backport af55553 to stable25 |
|
The backport to stable24 failed. Please do this backport manually. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the prevent download share permission added with nextcloud/server#32482
For now we block access through text fully