Skip to content

Conversation

juliusknorr
Copy link
Member

  • Backport of Yet another IE11 fixing round #1032
  • Additionally downgrade core-js since for some reason this version causes issues with String.split with the regex that is used by prosemirror-model where "block+".split(/\s*(?=\b|\W|$)/) would return ["b", "l", "o", "c", "k", "+"] instead of ["block+"]
    However the exact same version combinations work fine on master, so I assume there are some wild polyfills overriding each other

Related issue for core-js zloirock/core-js#810

Otherwise we need to keep up with each dependency if it is actually IE11 compatible

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Sep 11, 2020
@juliusknorr juliusknorr added this to the Nextcloud 19.0.4 milestone Sep 11, 2020
@juliusknorr juliusknorr merged commit cd0ef16 into stable19 Sep 14, 2020
@juliusknorr juliusknorr deleted the backport/stable19/1032 branch September 14, 2020 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants