-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(viewer): add Text, Markdown and Source Code viewer (read-only) #785
Conversation
5016d84
to
bf13cb8
Compare
Added many fixes separated into small commits. See PR description for new images.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know where it belongs code-wise, but I faced the caching issue:
- File is changed on server;
- Client is still keeping the old version (was empty for me);
Maybe could be done in a follow-up, but how can it better be done? Sync button, null cache time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, a text file has no ETag change after its content was changed... So technically the cached value is valid...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking with the office team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine if reopen after some short time, just not immediately after is was changes in the web-editor.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good from my POV
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
d344203
to
2a94e97
Compare
☑️ Resolves
Includes features:
.md
with extended markdown support.txt
with auto link only🖼️ Screenshots
Text file
Markdown file
Full-width mode
Soft-wrap - MD
Code (no highlighting)
Empty file
Copy content
Navigation
The text is within
contenteditable
, so a user can select/copy/navigate like in a text editor. But it is readonly.