Skip to content

fix: Update circles in cypress workflow #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025
Merged

fix: Update circles in cypress workflow #1809

merged 3 commits into from
May 22, 2025

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented May 21, 2025

No description provided.

@enjeck enjeck requested a review from blizzz as a code owner May 21, 2025 06:54
@enjeck enjeck force-pushed the fix-cypress-workflow branch 4 times, most recently from a0dca04 to bc1654f Compare May 21, 2025 07:43
@blizzz
Copy link
Member

blizzz commented May 21, 2025

The circles thing is fixed, yet there are failing tests against both 31 and master.

Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck enjeck force-pushed the fix-cypress-workflow branch 11 times, most recently from b74874b to 41dc6ca Compare May 22, 2025 00:05
Signed-off-by: Enjeck C <patrathewhiz@gmail.com>
@enjeck enjeck force-pushed the fix-cypress-workflow branch 6 times, most recently from a5742ce to b881223 Compare May 22, 2025 02:16
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck enjeck force-pushed the fix-cypress-workflow branch from b881223 to fdbae8d Compare May 22, 2025 04:40
@enjeck
Copy link
Contributor Author

enjeck commented May 22, 2025

The circles thing is fixed, yet there are failing tests against both 31 and master.

For the most part, the cy.type() failed because it targeted a disabled element error was caused by the previous operation which was modifying same input. So just swapping the operations fixed it 3a25757.

There were 2 more test cases outside of this that I address at fdbae8d, but these are still flaky and hope to find a more stable fix soon

@enjeck enjeck merged commit 42b247c into main May 22, 2025
69 of 73 checks passed
@enjeck enjeck deleted the fix-cypress-workflow branch May 22, 2025 05:27
@blizzz
Copy link
Member

blizzz commented May 22, 2025

Awesome @enjeck 🏅

@enjeck
Copy link
Contributor Author

enjeck commented May 23, 2025

/backport to stable0.8

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label May 23, 2025
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants