Enhancement: Make tables import asynchronous #1801
Conversation
Koc
force-pushed
the
feature/asyncronous-import
branch
from
5cbf833 to
3c2422c
Compare
|
Please keep in mind, existing API shall remain stable, but may be flagged deprecated. |
juliusknorr
added
enhancement
Koc
force-pushed
the
feature/asyncronous-import
branch
4 times, most recently
from
dba756c to
9b0c3bd
Compare
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
feature/asyncronous-import
branch
from
9b0c3bd to
1dbdfe8
Compare
|
@blizzz What exactly do you mean? Do not change already existent endpoint (keep it synchronous) but introduce v2/v3 for async tasks (even if this endpoints will be not in use on FE side)? |
| if ($userId) { | ||
| $this->userId = $userId; | ||
| } |
There was a problem hiding this comment.
I know that this looks ugly. But it needed because Tables has a lot of stateful services
| 'user_id' => $this->userId, | ||
| 'table_id' => $this->tableId, | ||
| 'view_id' => $this->viewId, | ||
| 'path' => $path, |
There was a problem hiding this comment.
please suggest how to deal with files that are uploaded from a browser (not selected from user's files in Nextcloud). Those files stored in /tmp until PHP finishes request. Should I use OCP\ITempManager for that?
Yes, exactly. The old ones can get the |
Right now module not ready to import large tables. This PR improves import flow by moving it into asynchronous job.
🗒️ TODO:
🔍 Preview
nextcloud-tables-2025-05-26_18.14.20.mp4