fix: get actual number of active users #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamza221
force-pushed
the
fix/active-users
branch
from
35375f1 to
e6a79aa
Compare
|
/backport to stable31 |
|
/backport to stable30 |
|
Thank you 🙏 I will review and test asap. @tcitworld what do you think? |
|
I'll check the failing oracle test tomorrow |
tcitworld
approved these changes
May 16, 2025
kesselb
reviewed
May 16, 2025
| ->where($queryBuilder->expr()->eq('appid', $queryBuilder->createNamedParameter('login'))) | ||
| ->andWhere($queryBuilder->expr()->eq('configkey', $queryBuilder->createNamedParameter('lastLogin'))) | ||
| ->andwhere($queryBuilder->expr()->gte( | ||
| $queryBuilder->expr()->castColumn('configvalue', IQueryBuilder::PARAM_INT), |
There was a problem hiding this comment.
OCI tests are failing because configvalue is a string and the other argument an integer.
My commit to cast configvalue to an int made Postgres and OCI unhappy 😆
There was a problem hiding this comment.
$queryBuilder->expr()->gte(
'configvalue',
$queryBuilder->createNamedParameter((string)$this->timeFactory->getTime() - $offset),
IQueryBuilder::PARAM_STR,
)
Treating both as string seems to work, but isn't that weird?
kesselb
force-pushed
the
fix/active-users
branch
2 times, most recently
from
3a52433 to
505c843
Compare
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
This was referenced May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #809
The existing logic checks the
authtokentable which comes with the tradeoff that user's row is deleted on logout.